Skip to content

Conversation

@Alessio-Falcini
Copy link

Description

This PR adds the rule prevalence information to the result document. This enhancement allows users to see how common a matched rule is, providing better context for analysis.

Changes

  • Modified capa/render/result_document.py to include prevalence data in the output.
  • Updated relevant tests in tests/test_result_document.py to verify the new field.

Motivation

Rule prevalence is a key indicator for analysts to distinguish between common behaviors and rare/anomalous capabilities. Including this in the standard result document makes the data more accessible

@google-cla
Copy link

google-cla bot commented Jan 26, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Alessio-Falcini, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the result document by incorporating rule prevalence information directly into the RuleMatches object. A new match_count field has been added to provide an explicit count of how many times a specific rule matched within an analyzed sample. This change aims to improve the accessibility of prevalence data in structured outputs, offering analysts a clearer context for distinguishing common behaviors from rare or anomalous capabilities without requiring additional processing.

Highlights

  • New match_count field: Introduced a new match_count field to the RuleMatches class in capa/render/result_document.py. This field explicitly stores the number of matches for a rule, providing a convenience for structured outputs like JSON.
  • Prevalence calculation: The from_capa method in capa/render/result_document.py now calculates and populates the match_count by counting the serialized_matches for each rule.
  • Test coverage: Added a new test test_match_count_from_capa in tests/test_result_document.py to ensure the match_count field is correctly populated when a ResultDocument is regenerated from capa data.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully introduces the rule prevalence information (match_count) into the result document, providing valuable context for analysis. The changes are well-implemented, including a clear definition of the new field in RuleMatches and its proper population during the from_capa conversion. The addition of serialized_matches improves readability and avoids redundant computation. Furthermore, the new test case test_match_count_from_capa thoroughly validates the functionality, ensuring the match_count field is correctly populated and accurate. Overall, this is a solid enhancement that improves the utility of the result document.

@Alessio-Falcini Alessio-Falcini force-pushed the feature/show-rule-prevalence branch from 2b93472 to f9266e0 Compare January 26, 2026 16:42
@github-actions github-actions bot dismissed their stale review January 26, 2026 16:43

CHANGELOG updated or no update needed, thanks! 😄

@Alessio-Falcini Alessio-Falcini force-pushed the feature/show-rule-prevalence branch from f9266e0 to 00a6d8a Compare January 26, 2026 16:50
@mr-tz
Copy link
Collaborator

mr-tz commented Jan 26, 2026

Please see the issue discussion and open PR for the intent of this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants