-
Notifications
You must be signed in to change notification settings - Fork 650
feat: show rule prevalence in result document #2841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: show rule prevalence in result document #2841
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
Summary of ChangesHello @Alessio-Falcini, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the result document by incorporating rule prevalence information directly into the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully introduces the rule prevalence information (match_count) into the result document, providing valuable context for analysis. The changes are well-implemented, including a clear definition of the new field in RuleMatches and its proper population during the from_capa conversion. The addition of serialized_matches improves readability and avoids redundant computation. Furthermore, the new test case test_match_count_from_capa thoroughly validates the functionality, ensuring the match_count field is correctly populated and accurate. Overall, this is a solid enhancement that improves the utility of the result document.
2b93472 to
f9266e0
Compare
CHANGELOG updated or no update needed, thanks! 😄
f9266e0 to
00a6d8a
Compare
|
Please see the issue discussion and open PR for the intent of this feature. |
Description
This PR adds the rule prevalence information to the result document. This enhancement allows users to see how common a matched rule is, providing better context for analysis.
Changes
capa/render/result_document.pyto include prevalence data in the output.tests/test_result_document.pyto verify the new field.Motivation
Rule prevalence is a key indicator for analysts to distinguish between common behaviors and rare/anomalous capabilities. Including this in the standard result document makes the data more accessible