Upgrade cloudlog to php 8.4 compatibility

[magicbug]

Upgrade Cloudlog to support PHP 8.4 by adding #[AllowDynamicProperties] to CI_Model and updating version references.

This PR enables Cloudlog to run on PHP 8.4. The changes are minimal and low-risk, primarily involving explicit dynamic property declarations for PHP 8.2+ compatibility and updating documentation/environment configurations.

---

 

[magicbug]

@copilot Do you think anything else in the codebase needs updated so that Cloudlog can support the latest version of PHP?

[cursor]

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on December 5.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

[Copilot]

@magicbug I've opened a new pull request, #3379, to work on those changes. Once the pull request is ready, I'll request review from you.

[Copilot]

Pull Request Overview

This PR aims to enable Cloudlog to run on PHP 8.4 by addressing deprecated features and adding compatibility attributes. The changes include handling deprecated E_STRICT constant, fixing mbstring.func_overload checks, adding #[AllowDynamicProperties] to CI_Model, updating version references, and attempting to address the deprecated session.sid_length INI setting.

• Conditionally handles E_STRICT constant that was deprecated in PHP 8.4
• Adds PHP 8.0+ checks before accessing mbstring.func_overload INI setting
• Adds #[AllowDynamicProperties] attribute to CI_Model for PHP 8.2+ compatibility
• Updates PHP version references in README, Dockerfile, and dashboard warnings
• Attempts to replace deprecated session.sid_length INI setting with a function call
• Includes comprehensive documentation of changes and compatibility analysis

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
system/core/Model.php	Adds #[AllowDynamicProperties] attribute for PHP 8.2+ dynamic property compatibility
system/core/Exceptions.php	Conditionally adds E_STRICT to error levels array only if constant is defined
index.php	Updates error reporting to conditionally exclude E_STRICT if defined
system/libraries/Session/Session.php	Attempts to use non-existent session_set_sid_length() function as replacement for deprecated INI setting
system/libraries/Zip.php	Adds PHP 8.0+ check before accessing deprecated mbstring.func_overload INI setting
system/libraries/Email.php	Adds PHP 8.0+ check before accessing deprecated mbstring.func_overload INI setting
system/libraries/Encryption.php	Adds PHP 8.0+ check before accessing deprecated mbstring.func_overload INI setting
system/core/Log.php	Adds PHP 8.0+ check before accessing deprecated mbstring.func_overload INI setting
system/libraries/Session/drivers/Session_files_driver.php	Adds PHP 8.0+ check before accessing deprecated mbstring.func_overload INI setting
system/core/compat/password.php	Adds PHP 8.0+ check before accessing deprecated mbstring.func_overload INI setting
application/views/dashboard/index.php	Updates PHP version warning to trigger for versions below 8.0.0 instead of 7.4.0 or lower
README.md	Updates documentation to reflect PHP 8.4 compatibility instead of PHP 8.2
Dockerfile	Updates base image from php:7.4-apache to php:8.4-apache
PHP_8.4_FIXES_APPLIED.md	New documentation file describing fixes applied (contains inaccurate information about session_set_sid_length)
PHP_8.4_COMPLETE_FIXES.md	New documentation file with complete fix summary (contains inaccurate information about session_set_sid_length)
PHP_8.4_COMPATIBILITY_ANALYSIS.md	New documentation file with compatibility analysis
APPLICATION_FOLDER_PHP_8.4_ANALYSIS.md	New documentation file analyzing application folder compatibility

[Copilot]

The code example shows usage of session_set_sid_length(), which is not a real PHP function. This example will not work as intended because the function doesn't exist, and the code will always fall back to using ini_set() which is deprecated in PHP 8.4.

[Copilot]

This claim is inaccurate. The session.sid_length deprecation warning will still occur in PHP 8.4 because the code attempts to use a non-existent function session_set_sid_length() and then falls back to the deprecated ini_set('session.sid_length', ...) call, which will trigger a deprecation warning.

[Copilot]

This comment is misleading. The function session_set_sid_length() does not exist in PHP. The comment should be updated to accurately reflect that session.sid_length is deprecated in PHP 8.4 with no direct replacement function, and explain what approach is being taken (e.g., continuing to use ini_set with awareness of the deprecation, or using @ to suppress the warning).

Suggested change

	// session.sid_length INI setting is deprecated in PHP 8.4, use session_set_sid_length() instead
	if (function_exists('session_set_sid_length'))
	// session.sid_length INI setting is deprecated in PHP 8.4. There is no direct replacement function.
	// We continue to use ini_set('session.sid_length', ...) for compatibility, but be aware this may trigger a deprecation warning in PHP 8.4+.
	if (function_exists('session_set_sid_length')) // Note: This function does not exist in PHP as of 8.4

[Copilot]

The function session_set_sid_length() does not exist in PHP. This code will always fall back to the ini_set() call, which defeats the purpose of this conditional check for PHP 8.4 compatibility.

In PHP 8.4, session.sid_length is deprecated as an INI setting, but there is no direct replacement function. The correct approach would be to either:

1. Suppress the deprecation warning with @ini_set('session.sid_length', $sid_length)
2. Accept the deprecation warning as it's non-fatal
3. Remove this code entirely as PHP 8.4's default session ID length is already secure

The current implementation incorrectly assumes a non-existent function exists.

Suggested change

	// session.sid_length INI setting is deprecated in PHP 8.4, use session_set_sid_length() instead
	if (function_exists('session_set_sid_length'))
	{
	session_set_sid_length($sid_length);
	}
	else
	{
	ini_set('session.sid_length', $sid_length);
	}
	// session.sid_length INI setting is deprecated in PHP 8.4+. There is no replacement function.
	// This will trigger a deprecation warning in PHP 8.4+, but is non-fatal.
	@ini_set('session.sid_length', $sid_length);

[Copilot]

This documentation incorrectly states that session_set_sid_length() is available in PHP 7.1+. This function does not exist in any version of PHP. The actual situation is that session.sid_length as an INI setting is deprecated in PHP 8.4 with no direct functional replacement - the setting can still be used but will trigger a deprecation notice.

[Copilot]

This documentation incorrectly states that session_set_sid_length() is a function available in PHP 7.1+. This function does not exist in any version of PHP. The documentation should be corrected to reflect the actual situation: session.sid_length as an INI setting is deprecated in PHP 8.4, but there is no direct replacement function.

Suggested change

	- **Fix**: Use `session_set_sid_length()` function when available (PHP 7.1+)
	- **Fix**: The `session.sid_length` INI setting is deprecated in PHP 8.4. There is no direct replacement function; code should avoid setting this value and rely on PHP defaults.