Skip to content

Conversation

@sedson
Copy link
Contributor

@sedson sedson commented Dec 30, 2025

Summary

Screenshots, GIFs, and Videos

@sedson sedson requested a review from a team as a code owner December 30, 2025 17:28
@linear
Copy link

linear bot commented Dec 30, 2025

Copy link
Contributor

@gbirman gbirman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

I pulled locally and a lot of these results still aren't working well imo. This is the content of the first one btw where it only grabbed the date:

" 29, 2025
<macro_em>Hey</macro_em> — quick reminder.
If you want to start 2026 with a"

Lmk if you need more examples to play around with.

also we have packages/core/util/searchHighlight.ts already I'd move the utils into there if possible

EDIT: saw that we didn't have a truncate search match markdown util on the email content match, lemme try that

@gbirman
Copy link
Contributor

gbirman commented Dec 30, 2025

CleanShot 2025-12-30 at 14 11 16@2x

ok looks email looks better with that util. BTW I'm noticing ## prevents markdown from highlighting the "hey" string from the image above, could you look into that:
"## <macro_em>Hey</macro_em> gbirman1998, let's verify your email address\nVerifying your email enables you to collaborate"

Copy link
Contributor

@gbirman gbirman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so here's the requested changes summary:

  • leave props.data.content as is in entitywitheverything and instead update packages/macro-entity/src/queries/search.ts getSearchData function to have:
content: YOUR_UTIL_FN(mergeAdjacentMacroEmTags(content)),
  • remove LexicalMarkdown/searchUtils and move the utils into packages/core/util/searchHighlight.ts

  • fix the ## bug I mentioned

@sedson sedson merged commit 11a5c8a into main Jan 5, 2026
19 checks passed
@sedson sedson deleted the seamus/m-5454-static-markdown-singleline-not-working-losing-info-during branch January 5, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants