Seanaye/feat/comms in soup #757
Open
+3,098
−1,573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanaye
force-pushed
the
seanaye/feat/comms-in-soup
branch
from
fa5d76f to
2f25b8b
Compare
seanaye
force-pushed
the
seanaye/feat/comms-in-soup
branch
8 times, most recently
from
52fd5ec to
627ae89
Compare
seanaye
force-pushed
the
seanaye/feat/comms-in-soup
branch
2 times, most recently
from
9998a89 to
693ceea
Compare
whutchinson98
approved these changes
Jan 6, 2026
Member
whutchinson98
left a comment
whutchinson98
left a comment
There was a problem hiding this comment.
overall seems good. though I think it's missing swagger
rust/cloud-storage/notification_service/src/notification/send/push/generate.rs
Show resolved
Hide resolved
seanaye
force-pushed
the
seanaye/feat/comms-in-soup
branch
from
14f9651 to
b0eda8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows returning the GET /channels equivalent data from soup while still respecting the sort and pagination of soup.
The existing endpoint should be mostly unchanged
Please review commit by commit
Screenshots, GIFs, and Videos