plugins.lunar: Clean up the code a bit, simplify things. #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous plugins.lunar seemed to sometimes get confused about what to do, leading to occasionally having plugins fail to be installed when they should have been. For instance, the dracut plugin on a fresh install wasn't being installed, causing a fresh install to fail to boot after installation finished. This cleans up the code a bit to, with any luck, make that not happen as much.
v4hn
reviewed
Apr 20, 2018
| fi | ||
|
|
||
| if SECTION=$(find_section $MODULE); then | ||
| for PLUGIN in $MOONBASE/$SECTION/$1/plugin.d/*.plugin |
Member
There was a problem hiding this comment.
This will fail when there is no plugin.d folder. True, it should always be there, but I can imagine better error handling than running
install -m 644 a/b/c/d/plugin.d/*.plugin $PLUGIN_DIR (or worse: it's rm equivalent)
below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous plugins.lunar seemed to sometimes get confused about what
to do, leading to occasionally having plugins fail to be installed when
they should have been. For instance, the dracut plugin on a fresh
install wasn't being installed, causing a fresh install to fail to boot
after installation finished.
This cleans up the code a bit to, with any luck, make that not happen as
much.