-
Notifications
You must be signed in to change notification settings - Fork 7
Php upgrade #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Php upgrade #34
Conversation
lulco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Označ ktoré časti sú bc pls
lulco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
primerguj si este mastra pls
lulco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vsade kde je mixed mam otazku: nevieme co to vrati?
vsade kde je v kode \Namespace\Class pouzi use nech to nemame v kode ale hore v use - idealne keby si zapol sniffer do github workflows - mozno takyto https://github.com/lulco/phoenix/blob/master/.github/workflows/codesniffer.yml
| parameters: | ||
| reportUnmatchedIgnoredErrors: false | ||
| ignoreErrors: | ||
| - '#^Method .* is unused\.$#' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fuha :)) k tomuto ta co viedlo? ci to kontroluje public metody ktore sa vramci libky nepouziju?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tu je problem ten, ze na lvl=max mi hadze unused metody, takze som dal ignore. Lenze na lvl=3 necekuje unused metody, tym padom hadze error, ze to pravidlo sa nepouziva. Preto som dal aj reportUnmatchedIgnoredErrors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nooo ale tak my budeme robit check len na jednom leveli (asi max) tak netreba ignorovat pre level 3
No description provided.