Skip to content

Conversation

@Carmagedon
Copy link

No description provided.

Copy link
Owner

@lulco lulco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Označ ktoré časti sú bc pls

Copy link
Owner

@lulco lulco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

primerguj si este mastra pls

Copy link
Owner

@lulco lulco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vsade kde je mixed mam otazku: nevieme co to vrati?
vsade kde je v kode \Namespace\Class pouzi use nech to nemame v kode ale hore v use - idealne keby si zapol sniffer do github workflows - mozno takyto https://github.com/lulco/phoenix/blob/master/.github/workflows/codesniffer.yml

parameters:
reportUnmatchedIgnoredErrors: false
ignoreErrors:
- '#^Method .* is unused\.$#'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fuha :)) k tomuto ta co viedlo? ci to kontroluje public metody ktore sa vramci libky nepouziju?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tu je problem ten, ze na lvl=max mi hadze unused metody, takze som dal ignore. Lenze na lvl=3 necekuje unused metody, tym padom hadze error, ze to pravidlo sa nepouziva. Preto som dal aj reportUnmatchedIgnoredErrors

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nooo ale tak my budeme robit check len na jednom leveli (asi max) tak netreba ignorovat pre level 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants