Modernize the gem structure and setup #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modernize the gem structure and setup to match that of fresh gem
generated with Bundler:
$ bundle gem active_remote
including an updated license, and new changelog and code of conduct.
The association DSL was defining collection association writer methods twice, which was triggering a warning from Ruby. Fix it.
Regenerate the RSpec spec helper, modernize the config, and drop rspec-its in favor of plain ol' `it` expectations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize the gem structure and setup to match that of fresh gem generated with Bundler:
including an updated license, and new changelog and code of conduct.
Also fix Ruby warnings, and drop
rspec-itsin favor of plain ol'itexpectations.