Update to parley 0.3 #883
Update to parley 0.3 #883
Conversation
|
Can anyone tell why cargo clippy keeps failing on macOS? I don't see an actual error message, just an error exit status. |
|
You have to fix the tests that call the same API |
There is expander. |
DJMcNab
left a comment
DJMcNab
left a comment
There was a problem hiding this comment.
One small nit, but otherwise LGTM.
Thanks!
masonry/examples/custom_widget.rs
Outdated
| text_layout.align( | ||
| None, | ||
| Alignment::Start, | ||
| AlignmentOptions { |
There was a problem hiding this comment.
I think we should use AlignmentOptions::default() here. The reason that the other parameters aren't in the options is because that Default impl exists (linebender/parley#283 (comment)), and we are using exactly the default value.
There was a problem hiding this comment.
Should I use AlignmentOptions::default() in the label widget too, or just in this example? And do you mean that I should use AlignmentOptions::default() instead of explicitly specifying the one option, or use ..AlignmentOptions::default() to allow for future extensibility?
There was a problem hiding this comment.
Apologies for the ambiguity. The first for both. That is, use AlignmentOptions::default() as the full parameter in both cases.
This update requires us to handle one breaking API change in parley.