WIP: Add support for per-side, symmetric, and uniform borders in BorderWidth #1555
+231
−90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Reason:
main goal is flexibility being able to style only the borders you care about instead of all sides at once.
Why is paint here:
without a paint method in BorderWidth, every widget that needs to draw borders would end up with a big if/else mess to handle 4 sides, symmetric cases, and uniform cases. putting the paint logic inside BorderWidth keeps that complexity in one place and avoids blotting the codebase with repeated drawing logic.
Notes:
i’m new to the codebase, so if this doesn’t fit the design direction i’m open to adjusting. border_color will follow in a separate change.