Add window resizing state management to MasonryState and `RenderCon…
#1551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text` This update introduces a new `resized_window` field in `MasonryState` to track the state of window resizing. The `on_window_resize_state_change` method in `RenderContext` is added to handle the resizing behavior for surfaces, particularly for macOS/Metal to avoid rendering artifacts during interactive resizing. This change enhances the rendering pipeline's responsiveness to window size changes.
PoignardAzur
reviewed
Jan 5, 2026
Contributor
PoignardAzur
left a comment
PoignardAzur
left a comment
There was a problem hiding this comment.
This seems fine? I don't have a Mac on hand to test this on, so I'd appreciate if someone could test this.
| /// Windows that are scheduled to be created in the next resumed event. | ||
| new_windows: Vec<NewWindow>, | ||
| need_first_frame: Vec<HandleId>, | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update introduces a new
resized_windowfield inMasonryStateto track the state of window resizing. Theon_window_resize_state_changemethod inRenderContextis added to handle the resizing behavior for surfaces, particularly for macOS/Metal to avoid rendering artifacts during interactive resizing.