Split off various modules into "editing" folder. #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beside code moves, the only changes in this PR are: - Changed imports. - Some items going from private to pub(crate).
Contributor
Author
|
I'm trying to redo the work from #237 in smaller chunks. This was the part people were most enthusiastic about. |
PoignardAzur
requested review from
DJMcNab and
nicoburns
and removed request for
nicoburns
DJMcNab
approved these changes
Oct 28, 2025
Member
DJMcNab
left a comment
DJMcNab
left a comment
There was a problem hiding this comment.
Other than the unmotivated TODO, this looks good.
| mod swash_convert; | ||
| mod util; | ||
|
|
||
| pub mod editing; |
Member
There was a problem hiding this comment.
There are arguments for this to be something like edit here, but editing is also fine.
Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beside code moves, the only changes in this PR are: