Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rust/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions rust/auth-impls/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,11 @@ pub(crate) struct Claims {
const BEARER_PREFIX: &str = "Bearer ";

impl JWTAuthorizer {
/// Create new instance of [`JWTAuthorizer`]
pub async fn new(jwt_issuer_key: DecodingKey) -> Self {
Self { jwt_issuer_key }
/// Creates a new instance of [`JWTAuthorizer`], fails on failure to parse the PEM formatted RSA public key
pub async fn new(rsa_pem: &str) -> Result<Self, String> {
let jwt_issuer_key =
DecodingKey::from_rsa_pem(rsa_pem.as_bytes()).map_err(|e| e.to_string())?;
Ok(Self { jwt_issuer_key })
}
}

Expand Down Expand Up @@ -74,7 +76,7 @@ mod tests {
use crate::JWTAuthorizer;
use api::auth::Authorizer;
use api::error::VssError;
use jsonwebtoken::{encode, Algorithm, DecodingKey, EncodingKey, Header};
use jsonwebtoken::{encode, Algorithm, EncodingKey, Header};
use serde::{Deserialize, Serialize};
use std::collections::HashMap;
use std::time::SystemTime;
Expand Down Expand Up @@ -132,7 +134,7 @@ mod tests {
)
.expect("Failed to create Encoding Key.");

let decoding_key = DecodingKey::from_rsa_pem(
let decoding_key = String::from(
"-----BEGIN PUBLIC KEY-----\
MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAysGpKU+I9i9b+QZSANu/\
ExaA6w4qiQdFZaXeReiz49r1oDfABwKIFW9gK/kNnrnL9H8P+pYfj7jqUJ/glmgq\
Expand All @@ -141,12 +143,10 @@ mod tests {
8YsTa5piV8KgJpG/rwYTGXuu3lcCmnWwjmbeDq1zFFrCDDVkaIHkGJgRuFIDPXaH\
yUw5H2HvKlP94ySbvTDLXWZj6TyzHEHDbstqs4DgvurB/bIhi/dQ7zK3EIXL8KRB\
hwIDAQAB\
-----END PUBLIC KEY-----"
.as_bytes(),
)
.expect("Failed to create Decoding Key.");
-----END PUBLIC KEY-----",
);

let jwt_authorizer = JWTAuthorizer::new(decoding_key).await;
let jwt_authorizer = JWTAuthorizer::new(&decoding_key).await.unwrap();

let valid_jwt_token =
encode(&Header::new(Algorithm::RS256), &claims, &valid_encoding_key).unwrap();
Expand Down
1 change: 1 addition & 0 deletions rust/server/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ edition = "2021"

[dependencies]
api = { path = "../api" }
auth-impls = { path = "../auth-impls" }
impls = { path = "../impls" }

hyper = { version = "1", default-features = false, features = ["server", "http1"] }
Expand Down
62 changes: 44 additions & 18 deletions rust/server/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,23 @@
#![deny(missing_docs)]

use std::net::SocketAddr;
use std::sync::Arc;

use tokio::net::TcpListener;
use tokio::signal::unix::SignalKind;

use hyper::server::conn::http1;
use hyper_util::rt::TokioIo;

use crate::vss_service::VssService;
use api::auth::{Authorizer, NoopAuthorizer};
use api::kv_store::KvStore;
use auth_impls::JWTAuthorizer;
use impls::postgres_store::{Certificate, PostgresPlaintextBackend, PostgresTlsBackend};
use std::sync::Arc;
use util::config::{Config, ServerConfig};
use vss_service::VssService;

pub(crate) mod util;
pub(crate) mod vss_service;
mod util;
mod vss_service;

fn main() {
let args: Vec<String> = std::env::args().collect();
Expand All @@ -33,22 +35,21 @@ fn main() {
std::process::exit(1);
}

let config = match util::config::load_config(&args[1]) {
Ok(cfg) => cfg,
Err(e) => {
eprintln!("Failed to load configuration: {}", e);
std::process::exit(1);
},
};

let addr: SocketAddr =
match format!("{}:{}", config.server_config.host, config.server_config.port).parse() {
Ok(addr) => addr,
let Config { server_config: ServerConfig { host, port }, jwt_auth_config, postgresql_config } =
match util::config::load_config(&args[1]) {
Ok(cfg) => cfg,
Err(e) => {
eprintln!("Invalid host/port configuration: {}", e);
eprintln!("Failed to load configuration: {}", e);
std::process::exit(1);
},
};
let addr: SocketAddr = match format!("{}:{}", host, port).parse() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot going on here. Can we declutter this? Btw, since we're already here, might make sense to switch this to the From<(I, u16)> for SocketAddr implementation rather than allocating a string and then parsing it again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is personal preference, but in the follow-up PR I consolidate the host and port setting into a single address setting, string type, ie "127.0.0.1:54234". We would then allocate the string upfront. WDYT ? Overall looking to reduce the number of lines in the config files, and the number of different settings. The address the server binds to is a single setting in my head :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah probably makes sense to make it one.

Ok(addr) => addr,
Err(e) => {
eprintln!("Invalid host/port configuration: {}", e);
std::process::exit(1);
},
};

let runtime = match tokio::runtime::Builder::new_multi_thread().enable_all().build() {
Ok(runtime) => Arc::new(runtime),
Expand All @@ -66,9 +67,33 @@ fn main() {
std::process::exit(-1);
},
};
let authorizer: Arc<dyn Authorizer> = Arc::new(NoopAuthorizer {});

let rsa_pem_env = match std::env::var("VSS_JWT_RSA_PEM") {
Ok(env) => Some(env),
Err(std::env::VarError::NotPresent) => None,
Err(e) => {
println!("Failed to load the VSS_JWT_RSA_PEM env var: {}", e);
std::process::exit(-1);
},
};
let rsa_pem = rsa_pem_env.or(jwt_auth_config.map(|config| config.rsa_pem));
let authorizer: Arc<dyn Authorizer> = if let Some(pem) = rsa_pem {
let authorizer = match JWTAuthorizer::new(pem.as_str()).await {
Ok(auth) => auth,
Err(e) => {
println!("Failed to parse the PEM formatted RSA public key: {}", e);
std::process::exit(-1);
},
};
println!("Configured JWT authorizer with RSA public key");
Arc::new(authorizer)
} else {
println!("No JWT authentication method configured");
Arc::new(NoopAuthorizer {})
};

let postgresql_config =
config.postgresql_config.expect("PostgreSQLConfig must be defined in config file.");
postgresql_config.expect("PostgreSQLConfig must be defined in config file.");
let endpoint = postgresql_config.to_postgresql_endpoint();
let db_name = postgresql_config.database;
let store: Arc<dyn KvStore> = if let Some(tls_config) = postgresql_config.tls {
Expand Down Expand Up @@ -109,6 +134,7 @@ fn main() {
Arc::new(postgres_plaintext_backend)
};
println!("Connected to PostgreSQL backend with DSN: {}/{}", endpoint, db_name);

let rest_svc_listener =
TcpListener::bind(&addr).await.expect("Failed to bind listening port");
println!("Listening for incoming connections on {}", addr);
Expand Down
6 changes: 6 additions & 0 deletions rust/server/src/util/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ use serde::Deserialize;
#[derive(Deserialize)]
pub(crate) struct Config {
pub(crate) server_config: ServerConfig,
pub(crate) jwt_auth_config: Option<JwtAuthConfig>,
pub(crate) postgresql_config: Option<PostgreSQLConfig>,
}

Expand All @@ -12,6 +13,11 @@ pub(crate) struct ServerConfig {
pub(crate) port: u16,
}

#[derive(Deserialize)]
pub(crate) struct JwtAuthConfig {
pub(crate) rsa_pem: String,
}

#[derive(Deserialize)]
pub(crate) struct PostgreSQLConfig {
pub(crate) username: Option<String>, // Optional in TOML, can be overridden by env
Expand Down
15 changes: 15 additions & 0 deletions rust/server/vss-server-config.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,21 @@
host = "127.0.0.1"
port = 8080

# Uncomment the table below to verify JWT tokens in the HTTP Authorization header against the given RSA public key,
# can be overridden by env var `VSS_JWT_RSA_PEM`
# [jwt_auth_config]
# rsa_pem = """
# -----BEGIN PUBLIC KEY-----
# MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAstPJs4ut+tFAI0qrOyGt
# /3FN5jWc5gLv/j9Rc6lgr4hm7lyR05PU/G+4rfxdXGNyGTlQ6dRqcVy78CjxWz9f
# 8l08EKLERPh8JhE5el6vr+ehWD5iQxSP3ejpx0Mr977fKMNKg6jlFiL+y50hOEp2
# 6iN9QzZQjLxotDT3aQvbCA/DZpI+fV6WKDKWGS+pZGDVgOz5x/RcStJQXxkX3ACK
# WhVdrtN3h6mHlhIt7ZIqVvQmY4NL03QPyljt13sYHoiFaoxINF/funBMCjrfSLcB
# ko1rWE2BWdOrFqi27RtBs5AHOSAWXuz/2SUGpFuTQuJi7U68QUfjKeQO46JpQf+v
# kQIDAQAB
# -----END PUBLIC KEY-----
# """

[postgresql_config]
username = "postgres" # Optional in TOML, can be overridden by env var `VSS_POSTGRESQL_USERNAME`
password = "postgres" # Optional in TOML, can be overridden by env var `VSS_POSTGRESQL_PASSWORD`
Expand Down