Skip to content

Conversation

@SylvainPlessis
Copy link
Contributor

This concerns the diffusion calculations, it computes modified diffusion terms to ensure computational stability with respect to vanishing concentrations.

This is the EG lib way of doing it, documentation of EG lib is here.

I'd like some agreement on the choice of the value of epsilon before merging.

// EGlib traces management, see doc: http://blanche.polytechnique.fr/www.eglib/manual.ps
// page 5
// EGlib uses eps = 1e-16
       typename raw_value_type<StateType>::type eps(std::numeric_limits<StateType>::epsilon() * 10);

@pbauman
Copy link
Member

pbauman commented Feb 11, 2016

@SylvainPlessis did you ever notice any actual large sensitivity due to this issue?

@SylvainPlessis
Copy link
Contributor Author

SylvainPlessis commented Apr 19, 2016

@pbauman, actually I've never play chemistry (transport, actually) in such conditions (almost pure). They did seem concerned about that in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants