Skip to content

Conversation

@fatelei
Copy link
Contributor

@fatelei fatelei commented Jan 25, 2026

Description

fix #580

add env

PIP_INDEX_URL=
PIP_EXTRA_INDEX_URL=
UV_INDEX_URL=
UV_EXTRA_INDEX_URL=

allow use index url to install plugin dep

fix race condition

errMsg and lastActiveAt in different coroutine, there is a race condition.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Please provide any additional context that would help reviewers understand the changes.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the flexibility and robustness of Python plugin dependency management. It introduces comprehensive support for configuring custom PyPI index URLs, allowing users to leverage private repositories or mirrors for faster and more controlled dependency resolution. Additionally, it addresses a critical race condition in the installation process and improves logging practices, making the system more stable, secure, and observable.

Highlights

  • PyPI Index Configuration: Introduced new environment variables (PIP_INDEX_URL, PIP_EXTRA_INDEX_URL, UV_INDEX_URL, UV_EXTRA_INDEX_URL) to allow users to specify custom PyPI index URLs for plugin dependency installation.
  • Precedence Logic for Indexes: Implemented specific precedence rules for applying these index URLs, differentiating between uv sync (for pyproject.toml) and uv pip install (for requirements.txt) to ensure correct mirror usage.
  • Race Condition Fix: Resolved a race condition during dependency installation by using sync.Mutex for error message accumulation and atomic.Int64 for tracking lastActiveAt timestamps, ensuring thread-safe updates.
  • Enhanced Logging & Security: Added detailed logging for the dependency installation process, including start/end times, and introduced a sanitizeArgs function to redact credentials from URLs in logs, improving security and observability.
  • Improved Output Handling: Refactored stdout/stderr reading during dependency installation to use bufio.Scanner for more reliable line-by-line processing, preventing potential buffer overflows and improving log clarity.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 25, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces valuable support for configuring PyPI index URLs, which will help speed up plugin dependency installations. The implementation is well-documented in the README. Additionally, the fix for the race condition during dependency installation is a critical improvement for the stability of the daemon. The enhanced logging, including sanitizing arguments to prevent credential leakage, is also a great addition.

I have two suggestions for improvement:

  1. Refactoring duplicated code in preparePipArgs and prepareSyncArgs to improve maintainability.
  2. Strengthening the argument sanitization logic to more robustly prevent credential leakage in logs.

@dosubot dosubot bot added enhancement New feature or request go Pull requests that update go code plugin-daemon labels Jan 25, 2026
@fatelei fatelei force-pushed the install_specific_pypi branch from ab8529b to f18bc7f Compare January 25, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request go Pull requests that update go code plugin-daemon size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

install plugin dep support pypi index

1 participant