-
Notifications
You must be signed in to change notification settings - Fork 274
feat: install plugin dep support pypi index url #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the flexibility and robustness of Python plugin dependency management. It introduces comprehensive support for configuring custom PyPI index URLs, allowing users to leverage private repositories or mirrors for faster and more controlled dependency resolution. Additionally, it addresses a critical race condition in the installation process and improves logging practices, making the system more stable, secure, and observable. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces valuable support for configuring PyPI index URLs, which will help speed up plugin dependency installations. The implementation is well-documented in the README. Additionally, the fix for the race condition during dependency installation is a critical improvement for the stability of the daemon. The enhanced logging, including sanitizing arguments to prevent credential leakage, is also a great addition.
I have two suggestions for improvement:
- Refactoring duplicated code in
preparePipArgsandprepareSyncArgsto improve maintainability. - Strengthening the argument sanitization logic to more robustly prevent credential leakage in logs.
ab8529b to
f18bc7f
Compare
Description
fix #580
add env
allow use index url to install plugin dep
fix race condition
errMsg and lastActiveAt in different coroutine, there is a race condition.
Type of Change
Essential Checklist
Testing
Bug Fix (if applicable)
Fixes #123orCloses #123)Additional Information
Please provide any additional context that would help reviewers understand the changes.