📝 Add docstrings to feat_patch
#131
Conversation
Docstrings generation was requested by @laike9m. * #98 (comment) The following files were modified: * `tests/assets/challenges/basic-foo-pyright-config/question.py` * `tests/conftest.py` * `tests/test_identical.py` * `views/challenge.py` * `views/views.py`
|
Important Review skippedCodeRabbit bot authored PR detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
laike9m
left a comment
laike9m
left a comment
There was a problem hiding this comment.
Great work on refactoring the type-checking logic and handling Pyright configurations!
I found one bug in tests/test_identical.py.
| challenge = Challenge( | ||
| name=challenge_name, level=Level(level), code=challenge_code | ||
| ) | ||
|
|
There was a problem hiding this comment.
This line should use path.open() instead of solution_file.open(). Currently, it always reads the content of solution_file regardless of the path argument.
Docstrings generation was requested by @laike9m.
The following files were modified:
tests/assets/challenges/basic-foo-pyright-config/question.pytests/conftest.pytests/test_identical.pyviews/challenge.pyviews/views.pyThese files were kept as they were
tests/test_challenge.pyThese file types are not supported
docs/Contribute.mdℹ️ Note