-
Notifications
You must be signed in to change notification settings - Fork 64
🐛 Fix sidebar banner overflow #734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🐛 Fix sidebar banner overflow #734
Conversation
…ctive Signed-off-by: xonas1101 <aarushsingh1305@gmail.com>
Signed-off-by: xonas1101 <aarushsingh1305@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubestellar-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Welcome to KubeStellar! 🚀 Thank you for submitting this Pull Request. Before your PR can be merged, please ensure: ✅ DCO Sign-off - All commits must be signed off with ✅ PR Title - Must start with an emoji: ✨ (feature), 🐛 (bug fix), 📖 (docs), 🌱 (infra/tests), Getting Started with KubeStellar: Contributor Resources:
🌟 Help KubeStellar Grow - We Need Adopters! Our roadmap is driven entirely by adopter feedback. Whether you're using KubeStellar yourself or know someone who could benefit from multi-cluster Kubernetes: 📋 Take our Multi-Cluster Survey - Share your use cases and help shape our direction! A maintainer will review your PR soon. Feel free to ask questions in the comments or on Slack! |
|
Hi @xonas1101. Thanks for your PR. I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: xonas1101 <aarushsingh1305@gmail.com>
|
well this does need some work to be done, when scrolling down, the banner disappears as it should, but the sidebar doesnt resize automatically. I'll look into it in some time. Till then can we review the other stuff? |
Signed-off-by: xonas1101 <aarushsingh1305@gmail.com>
Signed-off-by: xonas1101 <aarushsingh1305@gmail.com>
📌 Fixes
Fixes #722 (Use "Fixes", "Closes", or "Resolves" for automatic closing)
📝 Summary of Changes
Extraccted the SidebarFooter component from RelatedProjects.tsx.
Fixed the sidebar footer overflow by correctly accounting for both the navbar and banner heights.
Added a small 500ms delay before measuring layout because the banner and styles weren’t fully rendered on first load, which was causing height calculations to return 0 sometimes. This makes the layout stable and consistent on every load.
Changes Made
Checklist
Please ensure the following before submitting your PR:
Screenshots or Logs (if applicable)
Before: Sidebar footer overflowing when banner is visible

After: Sidebar layout fixed with proper banner height handling

👀 Reviewer Notes
Add any special notes for the reviewer here
This might need more refactors, I'll be happy to perform them, but for the time being, I think this works.