-
Notifications
You must be signed in to change notification settings - Fork 64
fix: support Jinja2 include-markdown directives for blank documentation pages #485 #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubestellar-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Welcome to KubeStellar! 🚀 Thank you for submitting this Pull Request. Before your PR can be merged, please ensure: ✅ DCO Sign-off - All commits must be signed off with ✅ PR Title - Must start with an emoji: ✨ (feature), 🐛 (bug fix), 📖 (docs), 🌱 (infra/tests), Getting Started with KubeStellar: Contributor Resources:
🌟 Help KubeStellar Grow - We Need Adopters! Our roadmap is driven entirely by adopter feedback. Whether you're using KubeStellar yourself or know someone who could benefit from multi-cluster Kubernetes: 📋 Take our Multi-Cluster Survey - Share your use cases and help shape our direction! A maintainer will review your PR soon. Feel free to ask questions in the comments or on Slack! |
|
Hi @rudy128. Thanks for your PR. I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@naman9271 @oksaumya please review and merge the pr |
Signed-off-by: Pratham Kamthan <prathamkamthan1306@gmail.com>
Signed-off-by: Pratham Kamthan <prathamkamthan1306@gmail.com>
Signed-off-by: Pratham Kamthan <prathamkamthan1306@gmail.com>
Signed-off-by: Pratham Kamthan <prathamkamthan1306@gmail.com>
Signed-off-by: Pratham Kamthan <prathamkamthan1306@gmail.com>
📖 Preview LinksThe following documentation pages were changed in this PR:
|
📌 Fixes
Fixes #485
Fixes #3565
📝 Summary of Changes
Fixed blank documentation pages caused by unsupported MkDocs-style Jinja2
{% include-markdown %}directives in the Nextra/Next.js framework.Problem
Several documentation pages were rendering completely blank on the live site because they used MkDocs-style
{% include-markdown %}directives that were not supported by Nextra. Affected pages included:/docs/contribution-guidelines/security/security-inc/docs/contribution-guidelines/security/security_contacts-inc/docs/contribution-guidelines/coc-inc/docs/contribution-guidelines/onboarding-inc/docs/contribution-guidelines/contributing-incSolution
Implemented support for Jinja2-style include directives in
src/app/docs/[...slug]/page.tsx:Changes Made
processInclude()helper function to handle all include directive processing with common logic{% include "path" %}{% include-markdown "path" start="<!--marker-->" end="<!--marker-->" %}{% include-markdown "path" %}start=""andend="")docs/content/directoryTechnical Details
[\s\S]*?to match multi-line Jinja2 directives../../../CONTRIBUTING.md)Checklist
Screenshots or Logs (if applicable)
✅ All affected pages now display content correctly
✅ Include directives properly resolved and content extracted
✅ Pages load successfully without errors
👀 Reviewer Notes
processInclude()function for maintainability