feat: added shutdownTime to extensions CRs

[vicentefb]

Fixes #108

This PR introduces shutdownTime feature to the sandbox extensions, allowing users to define an expiration time for their sandboxes.

1. A user can optionally provide a shutdownTime in their SandboxClaim.

This logic is implemented in the sandboxclaim-controller, which copies the correct shutdownTime to the Sandbox resource upon creation. The core sandbox-controller is then responsible for watching this field and deleting the sandbox pod when the time is reached.

[netlify]

✅ Deploy Preview for agent-sandbox canceled.

Name	Link
🔨 Latest commit	9ce884e
🔍 Latest deploy log	https://app.netlify.com/projects/agent-sandbox/deploys/692e0b7a1cf43d000898e133

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vicentefb
Once this PR has been reviewed and has the lgtm label, please assign janetkuo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @vicentefb. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[syangx39]

1. Do we have logic to prevent users from creating a Sandbox with shutdownTime in the past?
2. Also no action needed but please be aware we might have an up-to 2s deletion lag.

[vicentefb]

Do we have logic to prevent users from creating a Sandbox with shutdownTime in the past?

Thanks! Yes, there's this if statement in the sandbox controller that checks if the current time is after the shutdownTime https://github.com/kubernetes-sigs/agent-sandbox/blob/main/controllers/sandbox_controller.go#L448-L451

[hzxuzhonghu]

/lgtm

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[janetkuo]

/ok-to-test

[vicentefb]

/test presubmit-agent-sandbox-e2e-test

[janetkuo]

Please also see #201

[janetkuo]

I'm not sure why we are reconciling the claim time against the live sandbox here. What's the intention here? Claim doesn't support updating sandbox currently.

[vicentefb]

So i saw that the sandbox_controller.go allows and correctly handles updates to the shutdownTime field so in this case i was also allowing updates to the field from the SandboxClaim. Since the SandboxClaim is the user-facing interface, i thought users shouldn't need to find and edit the underlying Sandbox resource directly to change the field. I may be wrong by thinking about it like this but lmk if this makes sense or if i should revert this change.

[janetkuo]

This behavior is different from what's documented in the API spec

[vicentefb]

Ohh true, i forgot to update the API spec comments.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.