Misc2 #1352
Open
Misc2 #1352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terface Then hostapd needs to be restarted, handle this by adding the wifi container to the diff if a custom-phys-address has been changed on a Wi-Fi interface.
hostname can work, but from startup it does not, wg setconf fails and with that dagger.
Use the standard name instead of the marketing name, new syntax enable-80211ax, which is consistent with the nameing of the new roaming settings.
enable-reflector should be set to yes or no, not on off according to manpage.
Useful if you have multiple APs on one SSID.
troglobit
requested changes
Jan 14, 2026
Contributor
troglobit
left a comment
troglobit
left a comment
There was a problem hiding this comment.
Nice work! Only a suggestion for the mobility-domain type.
Comment on lines
+412
to
+415
| type string { | ||
| pattern '[0-9a-fA-F]{4}'; | ||
| } | ||
| default "4f57"; |
Contributor
There was a problem hiding this comment.
This is great, I noticed though that some use a hash of the SSID. OpenWRT for instance, do it like this: set_default mobility_domain "$(echo "$ssid" | md5sum | head -c 4)"
Maybe we should supply a union type here to make it easy to be compatible with OpenWRT as well?
typedef mobility-domain
{
type union {
type string {
pattern '[0-9a-fA-F]{4}';
}
type enumeration {
enum hash {
description
"Derive mobility domain by hashing the SSID.
OpenWrt-compatible: md5(ssid), first 4 hex chars.";
}
}
}
default "4f57";
description
"802.11r Mobility Domain identifier (4 hex digits).
Use 'hash' to derive it from the SSID.";
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: