ci(root): Add Dockerfile and docker-compose #666

gurkanguray · 2023-08-17T00:01:00Z

Description

Dockerfile and docker-compose.dev.yaml added to the root.
Single docker file, multi-target approach applied.
Workflow file added for docker checks.
Readme file updated with the new docker setup.
Sharp added as a new dependency. (ref: https://nextjs.org/docs/messages/install-sharp)

Checklist

discord username: gguray
Closes feat(ci/cd): setup docker #683
PR must be created for an issue from issues under "In progress" column from our project board.
A descriptive and understandable title: The PR title should clearly describe the nature and purpose of the changes. The PR title should be the first thing displayed when the PR is opened. And it should follow the semantic commit rules, and should include the app/package/service name in the title. For example, a title like "docs(@kampus-apps/pano): Add README.md" can be used.
Related file selection: Only relevant files should be touched and no other files should be affected.
I ran npx turbo run at the root of the repository, and build was successful.
I installed the npm packages using npm install --save-exact <package> so my package is pinned to a specific npm version. Leave empty if no package was installed. Leave empty if no package was installed with this PR.

How were these changes tested?

Tested on local and GitHub workflow file added.

vercel · 2023-08-17T00:01:06Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
kampus-studio	⬜️ Ignored (Inspect)	Visit Preview		Aug 23, 2023 3:57am

vercel · 2023-08-17T00:01:07Z

@gurkanguray is attempting to deploy a commit to the kamp-us Team on Vercel.

A member of the Team first needs to authorize it.

usirin · 2023-08-17T00:12:27Z

TY so much for this. I'll take a look ASAP.

Dockerfile

docker-compose.yaml

Ketcap · 2023-08-23T08:07:01Z

.env.example

@@ -0,0 +1,13 @@
+NODE_ENV=development


What is the reason we have an example env at the root. Since we have examples per folder that's good to move there where it matches

It was for the GitHub workflow testing purposes, and I will remove it in this PR.
https://github.com/marketplace/actions/create-env-file will handle the .env file creation at GitHub workflow for deployment purposes

Ketcap · 2023-08-23T08:08:53Z

Dockerfile

 RUN npm install
 COPY --from=gql-prune /app/out/full/ .
+COPY --from=gql-prune /app/out/full/apps/gql/.env.example ./apps/gql/.env
+COPY .env ./apps/pasaport/.env


@usirin should we make a small script to do this on local as well seems like right now .env.example files can run the applications so local env can utilise this too.

from what i read from the next.js docs, the best practice is to switch to a .env.development file and commit that. then people can create a .env.local file if they want to override anything from that files.

Good to know: .env, .env.development, and .env.production files should be included in your repository as they define defaults. .env*.local should be added to .gitignore, as those files are intended to be ignored. .env.local is where secrets can be stored.
https://nextjs.org/docs/app/building-your-application/configuring/environment-variables#default-environment-variables

Ketcap · 2023-08-23T08:09:52Z

Dockerfile

+RUN npm i -g concurrently

+# keep running
+CMD ["concurrently", "local-ssl-proxy --target 3000 --source 5000", "local-ssl-proxy --target 3001 --source 5001", "local-ssl-proxy --target 4000 --source 5002"]


can turbo run these ? turbo has concurrent running capability

at this point we don't need turbo, we pruned everything, and i am not even sure if there is a turbo binary at this point. i think it's better to go with this.

Ketcap · 2023-08-23T08:10:33Z

docker-compose.dev.yaml

    container_name: mysql
-    image: mysql
-    command: --default-authentication-plugin=mysql_native_password --skip-warnings
+    image: mysql:latest


i'd say let's define a version so everytime it's the same mysql.

Ketcap · 2023-08-23T08:10:54Z

docker-compose.dev.yaml

+  #    healthcheck: # TODO: Add healthcheck for kampus
+  #      test: [ "CMD", "curl", "-f", "http://localhost:3000" ]
+  #      interval: 30s
+  #      timeout: 10s
+  #      retries: 3


if not used please remove

Ketcap · 2023-08-23T08:11:36Z

package.json

    "prettier-plugin-tailwindcss": "0.3.0",
    "react": "18.2.0",
    "react-dom": "18.2.0",
+    "sharp": "^0.32.5",


it's not exact version and why we need this ?

It was added according to the following doc: https://nextjs.org/docs/messages/install-sharp. However, when I researched it more(https://nextjs.org/docs/pages/building-your-application/optimizing/images), this package is needed for built-in image optimizations, not docker images. It is a misunderstanding by me, and I will remove it 🙂

gurkanguray added 4 commits August 17, 2023 01:08

CI/CD (docker, docker-compose)

35eb6f4

removed unnecessary copies

09b5b4c

add github workflow file for docker checks

3cf3509

readme file updated

ff9dd05

gurkanguray requested a review from a team as a code owner August 17, 2023 00:01

gurkanguray requested review from rasitds and tw4 August 17, 2023 00:01

usirin requested review from sevilayerkan and usirin and removed request for tw4 August 17, 2023 22:23

Ketcap reviewed Aug 18, 2023

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

docker-compose.yaml Show resolved Hide resolved

gurkanguray added 3 commits August 19, 2023 02:51

optimized docker targets

5d2b0fa

more optimization on docker, and added helpful comments

38bb9f1

Merge branch 'dev' into dev

7daf678

vercel bot deployed to Preview – kampus-studio August 19, 2023 02:14 View deployment

gurkanguray added 2 commits August 19, 2023 05:16

comment refactor

8c05bf2

Merge branch 'dev' of github.com:gurkanguray/monorepo into dev

36cd42c

vercel bot deployed to Preview – kampus-studio August 19, 2023 02:17 View deployment

gurkanguray added 3 commits August 19, 2023 05:20

comment refactor

8524997

updated dockerfile syntax

d779748

ssl proxy added with refactor on docker files

9578d7f

gurkanguray requested a review from a team as a code owner August 23, 2023 03:45

vercel bot deployed to Preview – kampus-studio August 23, 2023 03:45 View deployment

gurkanguray added 4 commits August 23, 2023 06:50

Merge branch 'dev' into dev

37c7cd8

cleanup dockerfile

e244d29

Merge branch 'dev' of github.com:gurkanguray/monorepo into dev

20119c1

updated readme

415991c

Ketcap reviewed Aug 23, 2023

View reviewed changes

usirin added the work in progress label Sep 3, 2023

ci(root): Add Dockerfile and docker-compose #666

Are you sure you want to change the base?

ci(root): Add Dockerfile and docker-compose #666

Uh oh!

Conversation

gurkanguray commented Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

How were these changes tested?

Uh oh!

vercel bot commented Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Aug 17, 2023

Uh oh!

usirin commented Aug 17, 2023

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gurkanguray commented Aug 17, 2023 •

edited

Loading

vercel bot commented Aug 17, 2023 •

edited

Loading