driver-vnc: add as jumpstarter-all dependency #780

aesteve-rh · 2025-12-15T12:43:24Z

Summary by CodeRabbit

Chores
- Updated jumpstarter-all package to include VNC driver support.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Signed-off-by: Albert Esteve <aesteve@redhat.com>

netlify · 2025-12-15T12:43:29Z

✅ Deploy Preview for jumpstarter-docs ready!

Name	Link
🔨 Latest commit	`ebbc9fb`
🔍 Latest deploy log	https://app.netlify.com/projects/jumpstarter-docs/deploys/694007371a765d0008879aa0
😎 Deploy Preview	https://deploy-preview-780--jumpstarter-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

coderabbitai · 2025-12-15T12:43:34Z

Walkthrough

The pull request adds the "jumpstarter-driver-vnc" dependency to the meta-package manifest in packages/jumpstarter-all/pyproject.toml, extending the included drivers in the all-inclusive distribution.

Changes

Cohort / File(s)	Change Summary
Meta-package dependency addition `packages/jumpstarter-all/pyproject.toml`	Added "jumpstarter-driver-vnc" to the [project] dependencies list to include VNC driver support in the meta-package distribution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

add ssh driver to jumpstarter-all #708: Modifies the same meta-package manifest to add jumpstarter-driver-ssh dependency.
Add missing packages to jumpstarter-all #407: Modifies packages/jumpstarter-all/pyproject.toml to add multiple driver dependencies.
Add jumpstarter-driver-tmt to all package #672: Modifies the same dependency list in packages/jumpstarter-all/pyproject.toml to add jumpstarter-driver-tmt.

Suggested labels

backport release-0.7

Suggested reviewers

mangelajo
michalskrivanek

Poem

🐰 A driver hops into the fold,
VNC's magic now to behold,
The jumpstarter grows more complete,
With screens and sessions, oh how neat! 📺

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding the jumpstarter-driver-vnc dependency to the jumpstarter-all meta-package.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9214623 and cf09a12.

⛔ Files ignored due to path filters (1)

uv.lock is excluded by !**/*.lock

📒 Files selected for processing (1)

packages/jumpstarter-all/pyproject.toml (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

packages/*/pyproject.toml

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

Each package's pyproject.toml must include project metadata with Apache-2.0 license only

Files:

packages/jumpstarter-all/pyproject.toml

🧠 Learnings (15)

📓 Common learnings

Learnt from: CR
Repo: jumpstarter-dev/jumpstarter PR: 0
File: .cursor/rules/project-structure.mdc:0-0
Timestamp: 2025-11-27T09:58:55.346Z
Learning: Applies to packages/jumpstarter-driver-*/pyproject.toml : Driver packages must depend on `jumpstarter` and specific hardware libraries in their `pyproject.toml`

Learnt from: CR
Repo: jumpstarter-dev/jumpstarter PR: 0
File: .cursor/rules/project-structure.mdc:0-0
Timestamp: 2025-11-27T09:58:55.346Z
Learning: Applies to packages/jumpstarter-driver-*/pyproject.toml : Driver packages must register via the `jumpstarter.drivers` entry point in `pyproject.toml`

Learnt from: CR
Repo: jumpstarter-dev/jumpstarter PR: 0
File: .cursor/rules/project-structure.mdc:0-0
Timestamp: 2025-11-27T09:58:55.346Z
Learning: Applies to packages/jumpstarter-driver-*/pyproject.toml : Driver packages must follow the naming pattern `jumpstarter-driver-<name>`

Learnt from: CR
Repo: jumpstarter-dev/jumpstarter PR: 0
File: .cursor/rules/project-structure.mdc:0-0
Timestamp: 2025-11-27T09:58:55.346Z
Learning: Applies to packages/jumpstarter-driver-*/jumpstarter_driver_*/ : Driver packages must implement a `driver.py` file containing the driver implementation

Learnt from: CR
Repo: jumpstarter-dev/jumpstarter PR: 0
File: .cursor/rules/project-structure.mdc:0-0
Timestamp: 2025-11-27T09:58:55.346Z
Learning: Applies to packages/jumpstarter-cli-*/pyproject.toml : CLI packages must depend on `jumpstarter` and `jumpstarter-cli-common` in their `pyproject.toml`

Learnt from: CR
Repo: jumpstarter-dev/jumpstarter PR: 0
File: .cursor/rules/creating-new-drivers.mdc:0-0
Timestamp: 2025-11-27T09:58:41.875Z
Learning: Applies to packages/jumpstarter-driver-composite/pyproject.toml : Composite drivers that have child drivers should inherit from `CompositeClient` in `jumpstarter_driver_composite.client` and have a dependency on `jumpstarter-driver-composite` in `pyproject.toml`

Learnt from: CR
Repo: jumpstarter-dev/jumpstarter PR: 0
File: .cursor/rules/project-structure.mdc:0-0
Timestamp: 2025-11-27T09:58:55.346Z
Learning: Core packages must depend on `jumpstarter-protocol`

Learnt from: CR
Repo: jumpstarter-dev/jumpstarter PR: 0
File: .cursor/rules/project-structure.mdc:0-0
Timestamp: 2025-11-27T09:58:55.346Z
Learning: Applies to examples/*/pyproject.toml : Example packages should depend on relevant driver packages in their `pyproject.toml`

Learnt from: CR
Repo: jumpstarter-dev/jumpstarter PR: 0
File: .cursor/rules/creating-new-drivers.mdc:0-0
Timestamp: 2025-11-27T09:58:41.875Z
Learning: Applies to packages/jumpstarter-driver-**/jumpstarter_driver_**/*.py : Driver implementations should follow existing code style validated with `make lint` (fix with `make lint-fix`), perform static type checking with `make ty-pkg-${package_name}`, add comprehensive tests, and verify all tests pass with `make test-pkg-${package_name}` or `make test`

Learnt from: CR
Repo: jumpstarter-dev/jumpstarter PR: 0
File: .cursor/rules/creating-new-drivers.mdc:0-0
Timestamp: 2025-11-27T09:58:41.875Z
Learning: Applies to packages/jumpstarter-driver-*/pyproject.toml : Driver package names should be lowercase with hyphens for multi-word names (e.g., `my-driver`, `custom-power`, `device-controller`)

📚 Learning: 2025-11-27T09:58:55.346Z

Learnt from: CR
Repo: jumpstarter-dev/jumpstarter PR: 0
File: .cursor/rules/project-structure.mdc:0-0
Timestamp: 2025-11-27T09:58:55.346Z
Learning: Applies to packages/jumpstarter-driver-*/pyproject.toml : Driver packages must depend on `jumpstarter` and specific hardware libraries in their `pyproject.toml`

Applied to files:

packages/jumpstarter-all/pyproject.toml

📚 Learning: 2025-11-27T09:58:55.346Z

Learnt from: CR
Repo: jumpstarter-dev/jumpstarter PR: 0
File: .cursor/rules/project-structure.mdc:0-0
Timestamp: 2025-11-27T09:58:55.346Z
Learning: Applies to packages/jumpstarter-driver-*/pyproject.toml : Driver packages must register via the `jumpstarter.drivers` entry point in `pyproject.toml`

Applied to files:

packages/jumpstarter-all/pyproject.toml

📚 Learning: 2025-11-27T09:58:55.346Z

Learnt from: CR
Repo: jumpstarter-dev/jumpstarter PR: 0
File: .cursor/rules/project-structure.mdc:0-0
Timestamp: 2025-11-27T09:58:55.346Z
Learning: Applies to packages/jumpstarter-driver-*/pyproject.toml : Driver packages must follow the naming pattern `jumpstarter-driver-<name>`

Applied to files:

packages/jumpstarter-all/pyproject.toml

📚 Learning: 2025-11-27T09:58:55.346Z

Learnt from: CR
Repo: jumpstarter-dev/jumpstarter PR: 0
File: .cursor/rules/project-structure.mdc:0-0
Timestamp: 2025-11-27T09:58:55.346Z
Learning: Applies to packages/jumpstarter-cli-*/pyproject.toml : CLI packages must depend on `jumpstarter` and `jumpstarter-cli-common` in their `pyproject.toml`

Applied to files:

packages/jumpstarter-all/pyproject.toml

📚 Learning: 2025-11-27T09:58:55.346Z

Learnt from: CR
Repo: jumpstarter-dev/jumpstarter PR: 0
File: .cursor/rules/project-structure.mdc:0-0
Timestamp: 2025-11-27T09:58:55.346Z
Learning: Applies to packages/jumpstarter-driver-*/jumpstarter_driver_*/ : Driver packages must implement a `driver.py` file containing the driver implementation

Applied to files:

packages/jumpstarter-all/pyproject.toml

📚 Learning: 2025-11-27T09:58:41.875Z

Learnt from: CR
Repo: jumpstarter-dev/jumpstarter PR: 0
File: .cursor/rules/creating-new-drivers.mdc:0-0
Timestamp: 2025-11-27T09:58:41.875Z
Learning: Applies to packages/jumpstarter-driver-composite/pyproject.toml : Composite drivers that have child drivers should inherit from `CompositeClient` in `jumpstarter_driver_composite.client` and have a dependency on `jumpstarter-driver-composite` in `pyproject.toml`

Applied to files:

packages/jumpstarter-all/pyproject.toml

📚 Learning: 2025-11-27T09:58:41.875Z

Learnt from: CR
Repo: jumpstarter-dev/jumpstarter PR: 0
File: .cursor/rules/creating-new-drivers.mdc:0-0
Timestamp: 2025-11-27T09:58:41.875Z
Learning: Applies to packages/jumpstarter-driver-*/pyproject.toml : Driver package names should be lowercase with hyphens for multi-word names (e.g., `my-driver`, `custom-power`, `device-controller`)

Applied to files:

packages/jumpstarter-all/pyproject.toml

📚 Learning: 2025-11-27T09:58:55.346Z

Learnt from: CR
Repo: jumpstarter-dev/jumpstarter PR: 0
File: .cursor/rules/project-structure.mdc:0-0
Timestamp: 2025-11-27T09:58:55.346Z
Learning: Applies to examples/*/pyproject.toml : Example packages should depend on relevant driver packages in their `pyproject.toml`

Applied to files:

packages/jumpstarter-all/pyproject.toml

📚 Learning: 2025-11-27T09:58:55.346Z

Learnt from: CR
Repo: jumpstarter-dev/jumpstarter PR: 0
File: .cursor/rules/project-structure.mdc:0-0
Timestamp: 2025-11-27T09:58:55.346Z
Learning: Core packages must depend on `jumpstarter-protocol`

Applied to files:

packages/jumpstarter-all/pyproject.toml

📚 Learning: 2025-11-27T09:58:41.875Z

Learnt from: CR
Repo: jumpstarter-dev/jumpstarter PR: 0
File: .cursor/rules/creating-new-drivers.mdc:0-0
Timestamp: 2025-11-27T09:58:41.875Z
Learning: Applies to packages/jumpstarter-driver-**/jumpstarter_driver_**/*.py : Driver implementations should follow existing code style validated with `make lint` (fix with `make lint-fix`), perform static type checking with `make ty-pkg-${package_name}`, add comprehensive tests, and verify all tests pass with `make test-pkg-${package_name}` or `make test`

Applied to files:

packages/jumpstarter-all/pyproject.toml

📚 Learning: 2025-01-29T11:52:43.554Z

Learnt from: bennyz
Repo: jumpstarter-dev/jumpstarter PR: 241
File: packages/jumpstarter-driver-tftp/jumpstarter_driver_tftp/client.py:52-60
Timestamp: 2025-01-29T11:52:43.554Z
Learning: The TFTP driver (packages/jumpstarter-driver-tftp/jumpstarter_driver_tftp/driver.py) handles all low-level concerns like path validation, error handling, and checksum computation. The client (packages/jumpstarter-driver-tftp/jumpstarter_driver_tftp/client.py) should remain simple as it delegates these responsibilities to the driver.

Applied to files:

packages/jumpstarter-all/pyproject.toml

📚 Learning: 2025-11-27T09:58:41.875Z

Learnt from: CR
Repo: jumpstarter-dev/jumpstarter PR: 0
File: .cursor/rules/creating-new-drivers.mdc:0-0
Timestamp: 2025-11-27T09:58:41.875Z
Learning: Applies to packages/jumpstarter-driver-*/jumpstarter_driver_*/driver.py : Driver class names should be in CamelCase and be descriptive with appropriate suffixes based on functionality: Power drivers should end with `*Power`, Network drivers with `*Network`, Flasher drivers with `*Flasher`, Console drivers with `*Console`, Server drivers with `*Server`

Applied to files:

packages/jumpstarter-all/pyproject.toml

📚 Learning: 2025-09-06T05:25:18.184Z

Learnt from: michalskrivanek
Repo: jumpstarter-dev/jumpstarter PR: 608
File: packages/jumpstarter-cli/jumpstarter_cli/run.py:0-0
Timestamp: 2025-09-06T05:25:18.184Z
Learning: Zombie process reaping in jumpstarter is useful beyond just PID 1 cases, as drivers can leave behind processes in various execution contexts.

Applied to files:

packages/jumpstarter-all/pyproject.toml

📚 Learning: 2025-11-27T09:58:55.346Z

Learnt from: CR
Repo: jumpstarter-dev/jumpstarter PR: 0
File: .cursor/rules/project-structure.mdc:0-0
Timestamp: 2025-11-27T09:58:55.346Z
Learning: Applies to packages/jumpstarter-driver-*/jumpstarter_driver_*/ : Driver packages must implement a `client.py` file containing the client implementation

Applied to files:

packages/jumpstarter-all/pyproject.toml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)

GitHub Check: check-warnings
GitHub Check: build
GitHub Check: pytest-matrix (macos-15, 3.13)
GitHub Check: e2e
GitHub Check: pytest-matrix (ubuntu-24.04, 3.13)
GitHub Check: pytest-matrix (ubuntu-24.04, 3.11)
GitHub Check: pytest-matrix (macos-15, 3.12)
GitHub Check: pytest-matrix (macos-15, 3.11)
GitHub Check: pytest-matrix (ubuntu-24.04, 3.12)
GitHub Check: Redirect rules - jumpstarter-docs
GitHub Check: Header rules - jumpstarter-docs
GitHub Check: Pages changed - jumpstarter-docs

🔇 Additional comments (1)

packages/jumpstarter-all/pyproject.toml (1)

38-38: The addition is properly placed and the VNC driver package is fully structured.

The dependency is correctly positioned in alphabetical order between jumpstarter-driver-ustreamer and jumpstarter-driver-yepkit, follows the naming convention, and the driver package contains all required components: pyproject.toml with entry point registration, driver.py, and client.py.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

jumpstarter-backport-bot · 2025-12-22T16:29:58Z

Successfully created backport PR for release-0.7:

[Backport release-0.7] driver-vnc: add as jumpstarter-all dependency #786

driver-vnc: add as jumpstarter-all dependency

cf09a12

Signed-off-by: Albert Esteve <aesteve@redhat.com>

bennyz approved these changes Dec 15, 2025

View reviewed changes

Merge branch 'main' into vnc-driver-to-all

ebbc9fb

bennyz enabled auto-merge December 15, 2025 13:07

bennyz merged commit 882775c into jumpstarter-dev:main Dec 15, 2025
18 of 25 checks passed

mangelajo added the backport release-0.7 label Dec 22, 2025

jumpstarter-backport-bot bot mentioned this pull request Dec 22, 2025

[Backport release-0.7] driver-vnc: add as jumpstarter-all dependency #786

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

driver-vnc: add as jumpstarter-all dependency #780

driver-vnc: add as jumpstarter-all dependency #780

Uh oh!

aesteve-rh commented Dec 15, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

netlify bot commented Dec 15, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 15, 2025 •

edited

Loading

Uh oh!

Uh oh!

jumpstarter-backport-bot bot commented Dec 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

driver-vnc: add as jumpstarter-all dependency #780

driver-vnc: add as jumpstarter-all dependency #780

Uh oh!

Conversation

aesteve-rh commented Dec 15, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

netlify bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for jumpstarter-docs ready!

Uh oh!

coderabbitai bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

Uh oh!

jumpstarter-backport-bot bot commented Dec 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aesteve-rh commented Dec 15, 2025 •

edited by coderabbitai bot

Loading

netlify bot commented Dec 15, 2025 •

edited

Loading

coderabbitai bot commented Dec 15, 2025 •

edited

Loading