Skip to content

Conversation

@josbeir
Copy link
Owner

@josbeir josbeir commented Dec 25, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 25, 2025 10:57
@josbeir josbeir changed the title use plural names for commands and rename discover to cache command Rework commands Dec 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2025

Codecov Report

❌ Patch coverage is 97.46835% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.26%. Comparing base (20d0b4a) to head (26bf1fb).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/AttributeRegistryPlugin.php 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main       #5      +/-   ##
============================================
+ Coverage     94.96%   95.26%   +0.29%     
- Complexity      299      317      +18     
============================================
  Files            18       20       +2     
  Lines           954     1013      +59     
============================================
+ Hits            906      965      +59     
  Misses           48       48              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josbeir josbeir force-pushed the feat/rework-commands branch from b651bc5 to ea1477a Compare December 25, 2025 10:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames console commands to use plural naming convention ("attributes" instead of "attribute") and renames the "discover" command to "cache" to better reflect its functionality.

Key Changes:

  • Renamed command classes from Attribute{Action}Command to Attributes{Action}Command (e.g., AttributeListCommandAttributesListCommand)
  • Changed "discover" command to "cache" command (AttributeDiscoverCommandAttributesCacheCommand)
  • Updated command names from attribute {action} to attributes {action} (e.g., attribute listattributes list)
  • Updated command option flags (changed --no-discover to --clear-only)

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/ServiceProvider.php Updated command class imports and container registration to use new plural command class names
src/AttributeRegistryPlugin.php Updated command registration with new plural names and changed cache clear integration to use --clear-only flag
tests/TestCase/ServiceProviderTest.php Updated test assertions to reference new plural command class names
tests/TestCase/AttributeRegistryPluginTest.php Updated command name assertions to use new plural format
tests/TestCase/Command/AttributeListCommandTest.php Deleted old test file (presumably replaced with AttributesListCommandTest.php)
tests/TestCase/Command/AttributeInspectCommandTest.php Deleted old test file (presumably replaced with AttributesInspectCommandTest.php)
tests/TestCase/Command/AttributeDiscoverCommandTest.php Deleted old test file (presumably replaced with AttributesCacheCommandTest.php)
src/Command/AttributeListCommand.php Deleted old command file (presumably replaced with AttributesListCommand.php)
src/Command/AttributeInspectCommand.php Deleted old command file (presumably replaced with AttributesInspectCommand.php)
src/Command/AttributeDiscoverCommand.php Deleted old command file (presumably replaced with AttributesCacheCommand.php)
README.md Updated documentation with new command names and option flags throughout

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@josbeir josbeir merged commit c014db7 into main Dec 25, 2025
10 checks passed
@josbeir josbeir deleted the feat/rework-commands branch December 25, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants