-
Notifications
You must be signed in to change notification settings - Fork 1
Rework commands #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
============================================
+ Coverage 94.96% 95.26% +0.29%
- Complexity 299 317 +18
============================================
Files 18 20 +2
Lines 954 1013 +59
============================================
+ Hits 906 965 +59
Misses 48 48 ☔ View full report in Codecov by Sentry. |
b651bc5 to
ea1477a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR renames console commands to use plural naming convention ("attributes" instead of "attribute") and renames the "discover" command to "cache" to better reflect its functionality.
Key Changes:
- Renamed command classes from
Attribute{Action}CommandtoAttributes{Action}Command(e.g.,AttributeListCommand→AttributesListCommand) - Changed "discover" command to "cache" command (
AttributeDiscoverCommand→AttributesCacheCommand) - Updated command names from
attribute {action}toattributes {action}(e.g.,attribute list→attributes list) - Updated command option flags (changed
--no-discoverto--clear-only)
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ServiceProvider.php | Updated command class imports and container registration to use new plural command class names |
| src/AttributeRegistryPlugin.php | Updated command registration with new plural names and changed cache clear integration to use --clear-only flag |
| tests/TestCase/ServiceProviderTest.php | Updated test assertions to reference new plural command class names |
| tests/TestCase/AttributeRegistryPluginTest.php | Updated command name assertions to use new plural format |
| tests/TestCase/Command/AttributeListCommandTest.php | Deleted old test file (presumably replaced with AttributesListCommandTest.php) |
| tests/TestCase/Command/AttributeInspectCommandTest.php | Deleted old test file (presumably replaced with AttributesInspectCommandTest.php) |
| tests/TestCase/Command/AttributeDiscoverCommandTest.php | Deleted old test file (presumably replaced with AttributesCacheCommandTest.php) |
| src/Command/AttributeListCommand.php | Deleted old command file (presumably replaced with AttributesListCommand.php) |
| src/Command/AttributeInspectCommand.php | Deleted old command file (presumably replaced with AttributesInspectCommand.php) |
| src/Command/AttributeDiscoverCommand.php | Deleted old command file (presumably replaced with AttributesCacheCommand.php) |
| README.md | Updated documentation with new command names and option flags throughout |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.