fix: don't suggest rebase for merged PRs in status #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParseRepoFromURL now returns HOST/OWNER/REPO for non-github.com hosts (e.g., ghe.spotify.net/owner/repo) so the gh CLI knows which host to use. Previously it only returned OWNER/REPO which defaulted to github.com. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
GetAllPRs was fetching all PRs (open, closed, merged) which caused 502 Bad Gateway errors on repos with thousands of PRs. - Changed to fetch only open PRs (--state open) - Added fallback to check individual branch PRs for stack branches not in the open PR cache, ensuring merged PR detection still works - Removed merged PR filtering (no longer needed with targeted fetches) - Added verbose output showing fetched PRs for debugging Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Tests were failing because GetPRForBranch is now called for branches not in the PR cache (to detect merged PRs). Added mock expectations for these calls. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
javoire
force-pushed
the
fix/skip-merged-in-status
branch
from
e1949fb to
a8c7ae9
Compare
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
javoire
force-pushed
the
fix/skip-merged-in-status
branch
from
a8c7ae9 to
bb028a5
Compare
When there are no stack branches, code returns early before calling GetWorktreeBranches, GetRemoteBranchesSet, etc. Updated test to reflect the actual code path. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
When a branch's PR is merged, status was incorrectly reporting "needs rebase" because the branch is behind master. Merged branches don't need any action - skip them in sync issue detection. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
javoire
force-pushed
the
fix/skip-merged-in-status
branch
from
bb028a5 to
dc056da
Compare
javoire
force-pushed
the
fix/pr-fetching-multiple-remotes
branch
from
0a7c7b8 to
db91dbd
Compare
Owner
Author
|
🎉 This PR is included in version 1.7.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
detectSyncIssuesto avoid false "needs rebase" warningsstack syncalready handles merged PRs🤖 Generated with Claude Code