-
Notifications
You must be signed in to change notification settings - Fork 19
85 parameter remapping #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Details
| Benchmark suite | Current: 83c8ba2 | Previous: 36fa346 | Ratio |
|---|---|---|---|
edtf/natlang/tests.py::test_benchmark_natlang[23rd Dynasty-None] |
3896667.1054737167 iter/sec (stddev: 1.3840005306592688e-7) |
4045828.090756116 iter/sec (stddev: 4.5525769498448756e-8) |
1.04 |
edtf/natlang/tests.py::test_benchmark_natlang[January 2008-2008-01] |
4120696.885950153 iter/sec (stddev: 1.4235292503325525e-7) |
3627412.410458349 iter/sec (stddev: 1.6005526960808885e-7) |
0.88 |
edtf/natlang/tests.py::test_benchmark_natlang[ca1860-1860~] |
3796424.8205653843 iter/sec (stddev: 4.602628455285393e-8) |
3623835.2967353514 iter/sec (stddev: 1.5849056815471277e-7) |
0.95 |
edtf/natlang/tests.py::test_benchmark_natlang[uncertain: approx 1862-1862%] |
3783906.7266859263 iter/sec (stddev: 4.928374524812365e-8) |
3637589.0437032995 iter/sec (stddev: 1.1522462998676079e-7) |
0.96 |
edtf/natlang/tests.py::test_benchmark_natlang[January-XXXX-01] |
3850544.2824105197 iter/sec (stddev: 1.0599797210188732e-7) |
3626241.3627181253 iter/sec (stddev: 4.012117454455803e-8) |
0.94 |
edtf/natlang/tests.py::test_benchmark_natlang[Winter 1872-1872-24] |
3865065.231349897 iter/sec (stddev: 5.163098624691647e-8) |
3660710.8166115824 iter/sec (stddev: 1.1970693132718216e-7) |
0.95 |
edtf/natlang/tests.py::test_benchmark_natlang[before approx January 18 1928-/1928-01-18~] |
3800222.9262807686 iter/sec (stddev: 1.856995780382027e-7) |
3329160.4932871717 iter/sec (stddev: 4.352953943794583e-8) |
0.88 |
edtf/natlang/tests.py::test_benchmark_natlang[birthday in 1872-1872] |
3846056.679545249 iter/sec (stddev: 3.6370385350465614e-8) |
3695510.081302484 iter/sec (stddev: 1.300653813278426e-7) |
0.96 |
edtf/natlang/tests.py::test_benchmark_natlang[1270 CE-1270] |
3825154.7079341575 iter/sec (stddev: 1.4638310017436357e-7) |
3758071.4994793693 iter/sec (stddev: 1.7706240056339501e-7) |
0.98 |
edtf/natlang/tests.py::test_benchmark_natlang[2nd century bce--01XX] |
3844636.7719582072 iter/sec (stddev: 4.049496108164654e-8) |
3769485.3068561037 iter/sec (stddev: 1.856047419092188e-7) |
0.98 |
edtf/natlang/tests.py::test_benchmark_natlang[1858/1860-[1858, 1860]] |
3866661.8340933197 iter/sec (stddev: 1.8868176806269788e-7) |
3718318.787899858 iter/sec (stddev: 1.3913192900032567e-7) |
0.96 |
edtf/parser/tests.py::test_benchmark_parser[2001-02-03] |
175.6200500025684 iter/sec (stddev: 0.0005780411721517352) |
172.12621043455135 iter/sec (stddev: 0.0005996820802580561) |
0.98 |
edtf/parser/tests.py::test_benchmark_parser[2008-12] |
179.53432695815508 iter/sec (stddev: 0.0016336147425229622) |
182.10775640705626 iter/sec (stddev: 0.001409129218154591) |
1.01 |
edtf/parser/tests.py::test_benchmark_parser[2008] |
233.13386483113769 iter/sec (stddev: 0.0004987932007664678) |
230.49180147321488 iter/sec (stddev: 0.0004826480048373334) |
0.99 |
edtf/parser/tests.py::test_benchmark_parser[-0999] |
219.83054947518758 iter/sec (stddev: 0.0016058841894924444) |
215.9400104061111 iter/sec (stddev: 0.0013886473250614064) |
0.98 |
edtf/parser/tests.py::test_benchmark_parser[2004-01-01T10:10:10+05:00] |
157.16014468388326 iter/sec (stddev: 0.0004107186962915605) |
153.00340336159826 iter/sec (stddev: 0.0003564231898353574) |
0.97 |
edtf/parser/tests.py::test_benchmark_parser[-2005/-1999-02] |
122.31719238607135 iter/sec (stddev: 0.0018680219721144168) |
119.6065419515741 iter/sec (stddev: 0.00017539061544201887) |
0.98 |
edtf/parser/tests.py::test_benchmark_parser[/2006] |
281.8490524098306 iter/sec (stddev: 0.0002533547841677691) |
261.97749687330264 iter/sec (stddev: 0.0011747201812811168) |
0.93 |
edtf/parser/tests.py::test_benchmark_parser[?2004-%06] |
242.79942836843708 iter/sec (stddev: 0.0004137980919304289) |
236.91317649435496 iter/sec (stddev: 0.00032756775185827195) |
0.98 |
edtf/parser/tests.py::test_benchmark_parser[[1667, 1760-12]] |
20.180584480311715 iter/sec (stddev: 0.0019502450616734031) |
18.236448447287632 iter/sec (stddev: 0.002044393069779871) |
0.90 |
edtf/parser/tests.py::test_benchmark_parser[Y3388E2S3] |
454.44136337426744 iter/sec (stddev: 0.0001419099094307426) |
445.8229272981294 iter/sec (stddev: 0.0001084781927643624) |
0.98 |
edtf/parser/tests.py::test_benchmark_parser[2001-29] |
131.86838081911412 iter/sec (stddev: 0.001762720700271494) |
127.22914393879928 iter/sec (stddev: 0.001826311363375489) |
0.96 |
This comment was automatically generated by workflow using github-action-benchmark.
|
That looks great, thanks very much. Yes, please could you add a single test of the old parameter. |
|
Also, I guess we should run the tests form main during the CI process? |
Or else maybe move the tests out of out of the utils file and next to the other tests instead? |
Ok, tests moved and tests for parse_edtf() itself added. How's it look? |
|
That's great. Thanks very much. |
A decorator for parameter remapping, and applied it to the parse_edtf function.
The decorator should be in some other package if we want it elsewhere.
I exercise it in the
__main__section; did you want a test of the old parameter in the parser tests?