Navigation update #358
Draft
Navigation update #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add routes for post,user,community,message.
Ensure all modlog links use router.
Ensure all links in context menus use router.
Switch to router in navdrawer, userscreen and explore item.
Switch some routes to use router.
Switch some routes to use router.
Switch some routes to use router.
dart format lib/src/
Add helper for differences in accessing sqlite on web and native. Disable import/export database on web, hopefully temporary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe I've switched all the navigation across to using auto_route now. Next step is to make sure all the paths make sense and that path parameters match up.
I've also started on making sure it works on web. Two biggest issues so far seem to be with file io and checking the platform. Apparently
Platform.isAndroid,Platform.isLinuxetc don't work on web so I've had to add some util functions that check if it is web before checking the platform. Haven't switched out all the platform checks yet so some pages might throw errors but the main feed should show up on web now.It looks like a really big diff but most (~13K) of the added lines come from adding a file for drift to work on web. 'web/drift_worker.dart.js'