[v12] fix(ui-link): fix standalone link #2374
Open
+62
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
git-nandor
force-pushed
the
INSTUI-4896_fix_standalone_link
branch
from
ff7310f to
36e44f9
Compare
matyasf
reviewed
Jan 21, 2026
Comment on lines
-181
to
-182
| ? componentTheme.hoverTextDecorationWithinText | ||
| : componentTheme.hoverTextDecorationOutsideText |
Collaborator
There was a problem hiding this comment.
These tokens are unused now, can you ask design to delete them?
matyasf
requested changes
Jan 21, 2026
| '&:hover, &:active': { | ||
| '&:hover, &:active, &:focus': { | ||
| color: componentTheme.textHoverColor, | ||
| textDecoration: isWithinText |
Collaborator
There was a problem hiding this comment.
isWithinText is not used now, you can remove it from this file
adamlobler
approved these changes
Jan 22, 2026
git-nandor
force-pushed
the
INSTUI-4896_fix_standalone_link
branch
from
36e44f9 to
e309c9d
Compare
git-nandor
force-pushed
the
INSTUI-4896_fix_standalone_link
branch
from
01a1903 to
a7a01b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSTUI-4896
Summary
The standalone link had to be fixed due to an a11y requirement: interactive links must be underlined on interaction.
In addition, the Link component was rendering incorrectly and didn’t handle the new icons properly, so I fixed the way icons are rendered.
Test plan
Please check that standalone links also receive an underline during interaction (on hover or when tabbing). Also, verify that all links are displayed correctly on the documentation page.