-
Notifications
You must be signed in to change notification settings - Fork 107
[v12] feat(ui-source-code-editor): rework SourceCodeEditor #2319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
There are a lot of raw hex values in this component that doesn't have good contrast in the dark theme, I would add these as tokens if you agree.. |
a102a40 to
a57f948
Compare
matyasf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The contrast looks very bad in dark theme when something is selected:
I think you are setting the selection color wrong, this works for me: https://stackoverflow.com/a/78037621/319473
'.cm-selectionBackground, .cm-editor::selection': {
backgroundColor: componentTheme.focusedSelectionBackgroundColor + ' !important'
},
a57f948 to
fbabe26
Compare
matyasf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good now!
adamlobler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The activeLineColor should be applied that we discussed on slack, but other than that, I think it’s okay
fbabe26 to
8afb7ae
Compare
@adamlobler Updated it with the activeLineColor token, please check it |
adamlobler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor thing, the cursor is still black in dark mode as well, but if you insert this style it should work:
'&.cm-focused .cm-cursor': { borderLeftColor: componentTheme.color },
8afb7ae to
54bd94e
Compare
|
adamlobler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 🙌 Thank you!

INSTUI-4879
ISSUE:
SourceCodeEditor needs to be migrated to the new theming system
TEST PLAN: