Compatible group #336
Draft
Compatible group #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoura
requested changes
Dec 8, 2025
cardano_clusterlib/compat_common.py
Outdated
| from cardano_clusterlib import types as itp | ||
|
|
||
| if TYPE_CHECKING: | ||
| from cardano_clusterlib.clusterlib_klass import ClusterLib |
cardano_clusterlib/compat_common.py
Outdated
| self, | ||
| *, | ||
| name: str, | ||
| pool_params: structs.CompatPoolParams, |
Collaborator
There was a problem hiding this comment.
Why bundling all params to a single structure here? We already have PoolData structure for pool configuration, why nesting it into another structure?
cardano_clusterlib/compat_common.py
Outdated
| else: | ||
| default_owner = next(iter(pool_params.owner_stake_vkey_files)) | ||
| reward_arg = [ | ||
| "--pool-reward-account-verification-key-file", |
Collaborator
There was a problem hiding this comment.
No need to duplicate the arg name.
cardano_clusterlib/compat_common.py
Outdated
| self._base = ("cardano-cli", "compatible", era, "governance") | ||
| self.action = GovernanceActionGroup(clusterlib_obj, era) | ||
|
|
||
| def _resolve_mir_direct_args( |
Collaborator
There was a problem hiding this comment.
We don't need to support this "direct" way.
OlufemiAdeOlusile
force-pushed
the
alonzo_compatible_group
branch
from
a02df6d to
2e14ec5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cascading