Skip to content

Conversation

@alexfikl
Copy link
Collaborator

No description provided.

@alexfikl
Copy link
Collaborator Author

Some of those pyright errors seem to be specific to Python 3.12 + whatever else gets installed with it on the CI. I couldn't reproduce them on my normal Python 3.13 environment.

@alexfikl alexfikl marked this pull request as ready for review December 31, 2025 14:43
@inducer
Copy link
Owner

inducer commented Jan 1, 2026

Some of those pyright errors seem to be specific to Python 3.12

Oh man, thanks for pointing that out. I had been puzzling for a few months off-and-on why bpr produced different errors in CI than locally. Turns out I never even looked at or considered the Python version as a source of differences. 🤦

@alexfikl
Copy link
Collaborator Author

alexfikl commented Jan 1, 2026

Something seems to still be pulling in Python 3.12 from what I can tell:

    + python                        3.12.12  hd63d673_1_cpython    conda-forge         

EDIT: Ah, no, Python 3.14 gets pulled in later. Not sure why the same errors keep showing up though.. For what it's worth, I used

uv venv --python 3.12
uv pip install -r requirements.txt
uv pip install hatching editables ...

to get a Python 3.12 environment running and that seemed to make it happy.

@inducer
Copy link
Owner

inducer commented Jan 1, 2026

to get a Python 3.12 environment running and that seemed to make it happy.

Gah no. That's one step too far for me somehow.

@inducer
Copy link
Owner

inducer commented Jan 1, 2026

Turns out it was 3.14 in main, too. So that's another dead end. 🙁

@inducer
Copy link
Owner

inducer commented Jan 1, 2026

Alright, I'm back to being super puzzled. I'll just add some ignores next to those lines and call it a day. 😢

Feels like a waste of time.

@inducer inducer enabled auto-merge (rebase) January 1, 2026 13:30
@alexfikl
Copy link
Collaborator Author

alexfikl commented Jan 1, 2026

Alright, I'm back to being super puzzled. I'll just add some ignores next to those lines and call it a day. 😢

Yeah, can't say I have any other ideas and sifting through the differences between the uv venv and the CI doesn't seem productive :(

@inducer inducer merged commit 8c89204 into inducer:main Jan 1, 2026
7 checks passed
@alexfikl alexfikl deleted the fix-pyright branch January 1, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants