Better types 2024 #290
Merged
Better types 2024 #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inducer
force-pushed
the
better-types-2024
branch
from
32f010c to
88ce1cd
Compare
alexfikl
reviewed
Nov 28, 2024
Collaborator
alexfikl
left a comment
alexfikl
left a comment
There was a problem hiding this comment.
Left a few nitpicks, but overall adding some arithmetic to the types sounds good to me.
Maybe it's worth even making the default *T versions be arithmetic? I can't think of a case where we'd want to be more general..
inducer
force-pushed
the
better-types-2024
branch
from
88ce1cd to
432ba64
Compare
inducer
force-pushed
the
better-types-2024
branch
from
432ba64 to
3ce0c57
Compare
Owner
Author
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.