Skip to content

Improve dataclass container #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
inducer merged 1 commit into from
Nov 15, 2024
Merged

Improve dataclass container #288

inducer merged 1 commit into from
Nov 15, 2024

Conversation

@alexfikl
Copy link
Collaborator

@alexfikl alexfikl commented Nov 15, 2024

This updates dataclass_container with some new typing things:

  • Apparently A | B shows up as types.UnionType, not Union.
  • Also tuple[A, B] shows up as types.GenericAlias, which is not a subclass of typing._BaseGenericAlias.

@inducer inducer merged commit 22f9ead into inducer:main Nov 15, 2024
12 checks passed
@inducer
Copy link
Owner

inducer commented Nov 15, 2024

Thanks!

@alexfikl alexfikl deleted the improve-dataclass-container branch November 16, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexfikl @inducer