Skip to content

Sanitize input string in omerotools.parse_url #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ehrenfeu merged 3 commits into from
Jan 23, 2026
Merged

Sanitize input string in omerotools.parse_url #134

ehrenfeu merged 3 commits into from
Jan 23, 2026

Conversation

@rohangirishrao
Copy link
Contributor

@rohangirishrao rohangirishrao commented Jan 22, 2026

Fixes from #115: the issue of a trailing white space leading to the method crashing, and gracefully raises an error if the input string is empty.

@rohangirishrao
Sanitize input string
6a1a0d4 
Fixes the issue of a trailing whitespace leading to the method crashing.
@rohangirishrao
Handle empty input string gracefully
bec6f5a
@rohangirishrao rohangirishrao changed the title Sanitize input string in omerotools.parse_url Sanitize input string in omerotools.parse_url Jan 22, 2026
@rohangirishrao rohangirishrao linked an issue Jan 22, 2026 that may be closed by this pull request
Method crashes if link ends with a space #115
Closed
@rohangirishrao rohangirishrao mentioned this pull request Jan 22, 2026
Closed
@codecov
Copy link

codecov bot commented Jan 22, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 25%. Comparing base (d6ca59b) to head (2eb8ee2).
⚠️ Report is 29 commits behind head on devel.

Files with missing lines Patch % Lines
src/imcflibs/imagej/omerotools.py 0% 3 Missing ⚠️
Additional details and impacted files 
@@         Coverage Diff          @@
##           devel   #134   +/-   ##
====================================
- Coverage     25%    25%   -0%     
====================================
  Files         25     25           
  Lines       1771   1774    +3     
====================================
  Hits         437    437           
- Misses      1334   1337    +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ehrenfeu ehrenfeu self-requested a review January 22, 2026 15:06
@ehrenfeu ehrenfeu added bug Something isn't working next-release Issues blocking the next release changelog Needs to be mentioned in release changelogs labels Jan 22, 2026
@ehrenfeu ehrenfeu moved this to In review in imcflibs Jan 22, 2026
@ehrenfeu ehrenfeu added this to the 2.0.0 milestone Jan 22, 2026
@rohangirishrao rohangirishrao self-assigned this Jan 22, 2026
@rohangirishrao rohangirishrao mentioned this pull request Jan 22, 2026
Open
ehrenfeu
ehrenfeu requested changes Jan 22, 2026
View reviewed changes
@ehrenfeu ehrenfeu merged commit 9940daf into imcf:devel Jan 23, 2026
3 of 5 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in imcflibs Jan 23, 2026
@ehrenfeu
Copy link
Member

ehrenfeu commented Jan 23, 2026

Add to changelog #126

@rohangirishrao rohangirishrao deleted the fix-parse-url branch January 23, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehrenfeu ehrenfeu ehrenfeu approved these changes

Assignees

@rohangirishrao rohangirishrao

Labels

bug Something isn't working changelog Needs to be mentioned in release changelogs next-release Issues blocking the next release

Projects

imcflibs
Status: Done

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

Method crashes if link ends with a space

2 participants

@rohangirishrao @ehrenfeu