Skip to content

Conversation

@rohangirishrao
Copy link
Contributor

@rohangirishrao rohangirishrao commented Jan 14, 2026

@rohangirishrao rohangirishrao changed the base branch from master to devel January 14, 2026 14:29
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25%. Comparing base (4ebc024) to head (7cbcc19).
⚠️ Report is 6 commits behind head on devel.

Additional details and impacted files
@@         Coverage Diff          @@
##           devel   #123   +/-   ##
====================================
  Coverage     25%    25%           
====================================
  Files         25     25           
  Lines       1772   1764    -8     
====================================
  Hits         435    435           
+ Misses      1337   1329    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rohangirishrao rohangirishrao added the new-minor Change introduced in PR will require a new minor release. label Jan 14, 2026
@rohangirishrao rohangirishrao added this to the 2.0.0 milestone Jan 14, 2026
@ehrenfeu ehrenfeu added documentation Missing documentation, docstring conventions, ... new-major Change introduced in PR will require a new major release. and removed new-minor Change introduced in PR will require a new minor release. labels Jan 14, 2026
Copy link
Member

@ehrenfeu ehrenfeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, this method was introduced by @lguerard for a reason, as it does more than simply calling Objects3DPopulation.

Requests:

  • Discuss / approve with Laurent that it's okay to remove it.
  • Add it to the changelog in #126 as this is a breaking change.
  • Explain what to use instead (and how).

@ehrenfeu ehrenfeu moved this to In progress in imcflibs Jan 14, 2026
@ehrenfeu ehrenfeu linked an issue Jan 14, 2026 that may be closed by this pull request
@ehrenfeu
Copy link
Member

ehrenfeu commented Jan 14, 2026

Okay, obviously (and once again) I overlooked the related issue (#114) as it wasn't linked in the description - please avoid having issue numbers in new issue titles as my brain always gets tricked into thinking that number (in the title) is the number of this very issue / PR (not the referring one)... 🤦🏼

Instead, put the reference of the issue into the description and add it in the Development section on the right hand side.

Thanks! 🤗

@ehrenfeu ehrenfeu changed the title Remove objects method for issue #114 Remove method objects3d.get_objects_within_intensity Jan 14, 2026
@ehrenfeu
Copy link
Member

Merged back devel into this PR in order to fix the linting issues and to prevent merge conflicts.

🚨 @rohangirishrao please make sure to git pull in case you'd want to make further changes to this PR!!! 🚨

@ehrenfeu
Copy link
Member

A changelog-draft is available in #126, comment 3754046516.

Okay to be merged 🔀 ✅

@ehrenfeu ehrenfeu merged commit 4f26f83 into imcf:devel Jan 21, 2026
5 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in imcflibs Jan 21, 2026
@rohangirishrao rohangirishrao deleted the remove-objects-method branch January 22, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Missing documentation, docstring conventions, ... new-major Change introduced in PR will require a new major release.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Method get_objects_within_intensity is obsolete

2 participants