Add tests for listdir_matching
#122
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement tests for non-recursive and recursive matching. * Validate fullpath and regex matching functionality. * Ensure correct sorting behavior for file names.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #122 +/- ##
====================================
+ Coverage 25% 27% +2%
====================================
Files 25 25
Lines 1766 1766
====================================
+ Hits 435 470 +35
+ Misses 1331 1296 -35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ehrenfeu
changed the title
listdir_matching
ehrenfeu
approved these changes
Jan 21, 2026
Member
|
As indicated by codecov, there are still quite some paths in the function that are not covered by tests: https://app.codecov.io/gh/imcf/python-imcflibs/pull/122/blob/src/imcflibs/pathtools.py#L223 To me, the level of complexity / conditional nesting / ... of |
* Implement test for invalid regex returning an empty list. * Add test for recursive regex matching that verifies absolute paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #119