-
Notifications
You must be signed in to change notification settings - Fork 3
Add function to convert size from bytes to a more readable format #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #101 +/- ##
====================================
Coverage 25% 25%
====================================
Files 25 25
Lines 1766 1776 +10
====================================
+ Hits 435 441 +6
- Misses 1331 1335 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ehrenfeu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function name convert_bytes isn't really telling what it's actually doing, it only reveals the bytes are converted to something unknown.
Please rename it to human_bytes or similar.
|
Removed it from the current milestone as this is probably not blocking other code - feel free to re-add if you need it already now. |
10cfce6 to
6efda65
Compare
6efda65 to
073a1f7
Compare
|
I rebased this PR onto current 🚨 @lguerard please make sure to Let me know if you need help with this! |
- Implemented `bytes_to_human_readable` function to convert byte sizes into a more readable format. - Added unit tests for the new function to ensure accuracy across various sizes.
* Ensure common sizes are formatted into human-readable strings. * Verify formatting for large sizes such as terabytes.
Fixes #95