Update CMakeLists.txt #475
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test Update CMakeLists.txt
Author
|
This PR resolves the GTest build failure on ROS 2 Rolling by switching to ament_cmake_gtest. Please let me know if there’s anything else I should change. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the build failure of ifm3d_core on ROS 2 Rolling. The issue was caused by using a hardcoded GTest path (/usr/src/gtest), which is not available on the ROS 2 buildfarm.
I removed the hardcoded path and switched to using ament_cmake_gtest, which is the recommended way to add and run tests in ROS 2. I also added a test target for the existing logging test and linked it with the ifm3d_common module.