Skip to content

Conversation

@glesur
Copy link
Contributor

@glesur glesur commented Oct 18, 2025

Changed

Added

vreville and others added 30 commits December 3, 2024 10:57
…lay which slope limiter is used, fixed typo in the braginskii doc
updated ShowConfig functions from braginskii tc and viscosity to disp…
update changelog and version in develop
checking that everything works as expected)
glesur added 22 commits March 12, 2025 14:27
Fix SYCL loop auto-configuration
fix axis current regularisation along the south pole
Improve Wallclock dump outputs and add documentation (this feature has been around since 2.0.05, but not referenced)
* fix the energetic of ShearingBox+Fargo

The work done by the gravity force was not properly removed when using
fargo
* fix axis BX2s reconstruction when axis is not used on both sides of the
X2 domain (#342)

* fix reflective with MHD and DIMENSIONS < 3 (#343)
@glesur glesur requested a review from Copilot October 18, 2025 18:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request upgrades Idefix to version 2.2.02, incorporating several bug fixes and a new units module for explicit unit conversions. The changes address critical issues in profiling, energy budget calculations, boundary conditions, and magnetic field reconstruction while adding comprehensive documentation for continuous integration testing.

Key changes:

  • Added a units module that provides explicit unit conversion capabilities in CGS system
  • Fixed multiple bugs related to profiling, energy budget, boundary conditions, and dust physics
  • Enhanced documentation for continuous integration testing workflows

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/units.hpp New header defining the Units class with CGS constants and unit conversion methods
src/units.cpp Implementation of Units class methods for initialization and unit calculations
src/main.cpp Integration of units module into main application workflow
src/gravity/gravity.cpp Enhanced gravity module to support unit-based gravitational constant calculation
src/global.hpp/cpp Added global units object and profiling fence fix
src/fluid/drag.hpp Fixed parentheses placement in dust stopping time calculation
src/fluid/calcRightHandSide.hpp Corrected energy budget calculation for Fargo+shearing box scenarios
src/fluid/boundary/boundary.hpp Improved BX2 reconstruction and reflective boundary condition handling
src/fluid/boundary/axis.hpp/cpp Refactored axis boundary handling and removed debug output
src/fluid/addSourceTerms.hpp Removed duplicate Fargo source term causing energy budget issues
doc/source/* Added comprehensive CI testing documentation
CMakeLists.txt Updated version numbers and build configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

glesur and others added 3 commits October 18, 2025 20:52
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@glesur glesur requested a review from Copilot October 18, 2025 19:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/fluid/boundary/axis.hpp:1

  • Removed debug output statement that was likely left over from development. This change improves code cleanliness by removing unnecessary console output.
// ***********************************************************************************

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@glesur glesur merged commit 4a8b8a2 into master Oct 19, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants