Gen2 geometry and effvol extension #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…try and effective volume files
…ed loading of Gen2 simulation from config file
…or detector_signal, detector_hits, and significance calculation in simulation.py
…modification in detector.py for mixing_scheme = 'CompleteExchange'
… that allows arguments om_type and det_type, doubled WLS noise to account for both tubes
…me efficiencies in _compute_deadtime_efficiency for DOM and mDOM, use weighting of dead time efficiency based on the number of sensors in avg_dom_signal
…lation.py and detector.py
added 8 commits
June 22, 2025 14:12
sybenzvi
reviewed
Jun 22, 2025
Collaborator
There was a problem hiding this comment.
I'll comment here that the average DOM signal increased by about 1% in @jakob2508's branch compared to the main branch.
Collaborator
|
@sgriswol, other than the question of passing the effective volume tables as a dictionary or something else, this branch should be fairly up to date with the |
Collaborator
|
While checking the effective volume tables, I noticed a big spike in the depth value at z=-416.51m, with the effective volume
|
added 11 commits
June 24, 2025 09:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scripts
python/asteria/simulation.pyandphython/asteria/detector.pyhave been adapted to include the IceCube-Gen2 geometry and the effective volume of the mDOM. LOMs and other sensors will be included in the future. Wavelength shifters (WLS) are included in the form of WOM-Traps by scaling the effective volume of the mDOM by a scaling factor (similar to how the HQE DOMs in DeepCore are treated).For an example of how to use these new features please check out
scratch/sim_tester_Gen2.ipynb.Two minor changes
python/asteria/simulation.pyhave been made:avg_dom_signalnow calculates a weighted average of the effective volume based on the number of sensor of that type._compute_deadtime_efficiencynow applies the scaling based on a 1s binning instead of a 0.5s binning that was used before.