Skip to content

Conversation

@sensei-hacker
Copy link
Member

@sensei-hacker sensei-hacker commented Dec 24, 2025

User description

Summary

Adds cygwin1.dll to the Windows SITL build artifact so users can run the SITL executable without having Cygwin installed.

Changes

  • Add step to copy cygwin1.dll from /bin to build_SITL directory
  • Update upload-artifact to include both *.exe and cygwin1.dll

Related

Cherry-picked from #11133 (CI change only, without the FLYSPARKF4 line-ending changes)


PR Type

Enhancement


Description

  • Copies cygwin1.dll to Windows SITL build artifact

  • Updates artifact upload to include DLL dependency

  • Enables SITL executable to run without Cygwin installation


Diagram Walkthrough

flowchart LR
  A["Build SITL"] --> B["Strip version numbers"]
  B --> C["Copy cygwin1.dll"]
  C --> D["Upload artifacts"]
  D --> E["*.exe + cygwin1.dll"]
Loading

File Walkthrough

Relevant files
Configuration changes
ci.yml
Add cygwin1.dll to Windows SITL artifact                                 

.github/workflows/ci.yml

  • Added step to copy cygwin1.dll from /bin to build_SITL directory
  • Updated artifact upload path to include both *.exe files and
    cygwin1.dll
  • Enables Windows SITL executable to run without requiring Cygwin
    installation
+5/-1     

Adds cygwin1.dll to the Windows SITL build artifact so users
don't need Cygwin installed to run the SITL executable.

Cherry-picked from PR iNavFlight#11133.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@qodo-code-review
Copy link
Contributor

ⓘ Your approaching your monthly quota for Qodo. Upgrade your plan

PR Compliance Guide 🔍

All compliance sections have been disabled in the configurations.

@sensei-hacker sensei-hacker merged commit 8b58427 into iNavFlight:maintenance-9.x Dec 24, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant