Fix progress #40
Closed
Fix progress #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay need to revisit this later
* Add sign option to tree.grad() * Report granular/detailed losses Need to update conventional engines, as well as server/web interface * Granular losses for conventional engines * Fix web interface w/ granular losses * Typing fixes * Print detailed error breakdown * Hotfix for prepare_for_engine backend error
Owner
|
Looks like we still ended up with some extra stuff in fix-progress, I'll take a look. No need for a PR |
Owner
|
this is suspicious for instance: |
Owner
|
Do you know if it's still erroring with the current develop branch? It looks like there are casts in the right place currently |
Collaborator
Author
|
Code works as expected on the develop branch, didn't catch the recent commits to develop |
Collaborator
Author
|
Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.