Clamp amplitude #38
Closed
Clamp amplitude #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexane360
requested changes
Nov 3, 2025
Owner
hexane360
left a comment
hexane360
left a comment
There was a problem hiding this comment.
A small change for clarity, also remove redundant imports
|
|
||
| @partial(jit, donate_argnames=('obj',), cupy_fuse=True) | ||
| def clamp_amplitude(obj: NDArray[numpy.complexfloating], amplitude: t.Union[float, numpy.floating]) -> NDArray[numpy.complexfloating]: | ||
| def clamp_amplitude(obj: NDArray[numpy.complexfloating], amplitude: t.Union[float, numpy.floating, t.List[float]]) -> NDArray[numpy.complexfloating]: |
Owner
There was a problem hiding this comment.
Cleaner to take min and max as optional parameters.
Then the implementation can be something like:
new_amp = obj_amp
if min is not None and max is not None:
new_amp = xp.clip(new_amp, min_amp, max_amp) # faster than doing sequentially
elif min is not None:
new_amp = xp.maximum(new_amp, min_amp)
elif max is not None:
new_amp = xp.minimum(new_amp, max_amp)
Owner
There was a problem hiding this comment.
You can split into min and max in the constructor of ClampObjectAmplitude
Co-authored-by: Colin Gilgenbach <colin@gilgenbach.net>
Co-authored-by: Colin Gilgenbach <colin@gilgenbach.net>
Co-authored-by: Colin Gilgenbach <colin@gilgenbach.net>
Owner
|
Did my previous comments make sense? I re-requested the same changes to the code |
Author
|
Yes I thought I had changed them according to what you suggested? Did they not go through? |
Owner
|
Specifically this: #38 (comment) |
Author
|
I thought I did (see change and git push). |
Owner
|
None of those changes seem to have to do with ClampObjectAmplitude, and you haven't split the function parameters, did you understand what I was asking? |
hexane360
approved these changes
Nov 12, 2025
hexane360
pushed a commit
that referenced
this pull request
Nov 12, 2025
can accept either a list [lower_bound, upper_bound] or a single value which is the upper bound Merges pull request #38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding lower bound to clamp amplitude -- can accept either a list [lower_bound, upper_bound] or a single value which is the upper bound