feat(curations): Update curations schema #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Models imported from https://github.com/oss-review-toolkit/ort/tree/main/integrations/schemas Python utility datamodel-code-generator initially used and later manual deduplication. Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <helio.chissini.de.castro@cariad.technology>
Signed-off-by: Helio Chissini de Castro <helio.chissini.de.castro@cariad.technology>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
- Move all relevant models to models folder - Add Ort current schemas for repository configuration - Add base script to use data-model-generate properly - Add simple tests for repository-configuration - Remove mypy and pyright in favor of pyrefly only Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
First public release of Python ort
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the python-ort library dependencies and adds new fields to support package curations. The key changes include:
- Dependency version bumps for multiple packages (pydantic, pyrefly, ruff, etc.)
- Addition of a new
SourceCodeOriginenum - New fields in
CurationsSchemaCurationsSchemaItemCurations:purl,cpe,source_code_origins, andlabels - Reordering of existing fields in the curations model
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Updated dependency versions for argcomplete, datamodel-code-generator, filelock, idna, iniconfig, platformdirs, pydantic, pydantic-core, pyrefly, pytokens, ruff, tomli, and virtualenv |
| src/ort/models/source_code_origin.py | Added new enum for VCS and ARTIFACT source code origins |
| src/ort/models/repository_configuration.py | Added new fields to curations model and imported SourceCodeOrigin |
| schemas/curations-schema.json | Updated JSON schema with new enum and fields |
| pyproject.toml | Bumped project version and dependency requirements |
| .pre-commit-config.yaml | Updated pre-commit hook versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+325
to
+327
| declared_license_mapping: dict[str, Any] = Field(default_factory=dict) | ||
| source_code_origins: list[SourceCodeOrigin] | None = None | ||
| labels: dict[str, str] = Field(default_factory=dict) |
There was a problem hiding this comment.
[nitpick] The new fields declared_license_mapping and labels use Field(default_factory=dict) which differs from the existing pattern where optional fields use | None = None. Consider using | None = None instead for consistency, or document why these fields should default to empty dicts instead of None.
Suggested change
| declared_license_mapping: dict[str, Any] = Field(default_factory=dict) | |
| source_code_origins: list[SourceCodeOrigin] | None = None | |
| labels: dict[str, str] = Field(default_factory=dict) | |
| declared_license_mapping: dict[str, Any] | None = None | |
| source_code_origins: list[SourceCodeOrigin] | None = None | |
| labels: dict[str, str] | None = None |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.