Skip to content

[DRAFT] - Filter type refactoring #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AlexejKossmann wants to merge 60 commits into
base: master
Choose a base branch
from
Open

[DRAFT] - Filter type refactoring #19

AlexejKossmann wants to merge 60 commits into from

Conversation

@AlexejKossmann
Copy link
Contributor

@AlexejKossmann AlexejKossmann commented Apr 19, 2021 •
edited
Loading

This is the enchancement and fix for FilterTypes. After this every FilterType should only have options it actually supports.

DOTO:

  • add Text Type
  • add Choice Type
  • add DateTime Type
  • add Button Type
  • add QueryBuilder Helper
  • extend FilterTextType
  • extend ChoiceType
  • extend DateTimeType
  • extend ButtonType
  • extend Template for FilterTextType, ChoiceType, DateTimeType, ButtonType
  • write tests

Alexej Kossmann added 30 commits February 19, 2021 17:38
work in progress
d6a3753
added filterTypes to backend selection
a659db9
added difference between initial and not initial filters
630d399
refactored context assignemnt
9ae57b5
refactoring
84b2e07
fixed selecting of intial palette
1a29079
added template, started orm filter query
f891273
working on querybuilder
a2605e6
added querybuilder where for TextFilterType
ef3e234
added processing of queryParts
4730781
text-type working
fbf0997
added basic choice_type
ae8d55c
added more configuration options for choice type
bb96233
working on datetimetype
c8a1360
added whereQueryBuilder merhod to QueryPart class, working on dateTim…
900ad15 
…eType
removed queryBuilder from FilterTypeContext, added dca to FilterQuery…
79c4658 
…Part->composerWhereForQueryBuilder
first buttonType implementation
7dd779f
added html5 to datetimeType, working button type
2efd6ba
fixed resetButton to be submitButton, and still reset the form
b6dd843
refactored queryPart and queryPartProcessor
c477fa4
added visual improvements to filterTypes
2d80b5e
refactoring and fixing datetimeTyp
153b433
fixed code style
5085895
fixed datetime format issue, to break form on wrong data value
33c4fcc
fixed data option for choiceType
4b06c14
fixed code style
e491887
refactored FilterTypeContext, FilterQueryPart, FilterQueryProcessor, …
58cce7e 
…extended Event
added deprecations
5ca0331
added initialValue and initialValueType
ca4cc6b
added intial filter handling, added new filter option for overriding …
6c5d439 
…initial filters
Alexej Kossmann added 16 commits April 29, 2021 10:36
refactored type and reordered new classes
2095107
refactored deprecated options on type dropdown
6a58d73
refactored defaultOperator for legacy types
3458736
fixed error not retrieving correct pageId on multiple following async…
248758c 
… submits
refactored is null issue fix
a17c2d2
fixed async form submit, adjusted choiceType for form reset
b027462
added github actions
eeb386c
added tests for TextType and FilterQueryPart
1d4dc64
fixed and added tests for FilterQueryPartCollection
a70d0cc
added more options to choiceType
78c5d23
refactored initialValueChoices
0b7754f
fixed corrupted options array for filterTypes
580b28f
added translation and deprecated all old filtertypes
89e52f1
fixed initial value of choice
3d60c19
fixed method signatures
0ed1dd0
excluded test for deprecated files
c70f436
@koertho koertho mentioned this pull request Jul 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koertho koertho Awaiting requested review from koertho

@Defcon0 Defcon0 Awaiting requested review from Defcon0

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexejKossmann @koertho