Adding support for msvc. #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @Luiz-Monad that's pretty nice, thanks for the support. We actually have moved this project in a startup project named nxxm.io where we have the support for msvc included by default and much more (webassembly on all platforms). We still have bugs in the current release with msvc though, but they should be fixed this month. May I ask you in which context you use inglued ? Could we perhaps have a chat, so that we can know how we can improve it ? |
daminetreg
requested changes
Sep 4, 2020
|
|
||
| auto scan_inglued_dep = [](const fs::path& glue_file) { | ||
| auto deep_deps = read_deps(glue_file.native()); | ||
| auto deep_deps = read_deps((const std::string &)glue_file.native()); |
Member
There was a problem hiding this comment.
Perhaps the correct fix would be using glue_file.string() but that may require updating Boost, as they has been some change in Boost filesystem since this code was written and in this area.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, nice project.
I managed to compile in msvc with some small changes.