CropController uses GridClient for the get source image call to Media API #4518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonytw1
force-pushed
the
eelpie/cropper-uses-gridclient-for-image-details
branch
from
61f8002 to
1e4c97e
Compare
tonytw1
force-pushed
the
eelpie/cropper-uses-gridclient-for-image-details
branch
from
1e4c97e to
9c3a5ca
Compare
tonytw1
force-pushed
the
eelpie/cropper-uses-gridclient-for-image-details
branch
from
9c3a5ca to
970fc60
Compare
andrew-nowak
reviewed
Oct 2, 2025
| @@ -0,0 +1,16 @@ | |||
| package controllers | |||
|
|
|||
| trait MediaApiUrls { | |||
Member
There was a problem hiding this comment.
definitely nitpicking here, but I think I'd have a mild preference for helpers like this without any dependencies to be in an object rather than a trait
Suggested change
| trait MediaApiUrls { | |
| object MediaApiUrls { |
Contributor
Author
There was a problem hiding this comment.
Yes. This looks better.
Import MediaApiUrls._ and lose the with MediaApiUrls
Amended and rebased.
andrew-nowak
approved these changes
Oct 2, 2025
Member
andrew-nowak
left a comment
andrew-nowak
left a comment
There was a problem hiding this comment.
lgtm, let me know if you disagree with my nitpick and I can merge as is
… API. Moving this call to GridClient helps to enclosure all the service to service URL and HTTP client concerns in one place. This call was probably the only service to service call circa 2021. GridClient seems to be how more recent service to service calls are done. Get SourceImage requests additional fields via media-api query parameters so add queryStringParameters parameter to makeGetRequestAsync. Extract the media api uri to image id validation to a function for testing and make it validate image URIs rather than blanket Media API.
tonytw1
force-pushed
the
eelpie/cropper-uses-gridclient-for-image-details
branch
from
970fc60 to
1f45970
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Cropper uses GridClient for it's RPC to Media API.
Moving this call to GridClient helps to enclosure all the service to service URL and HTTP client concerns in one place.
This makes life slightly easier for anyone thinking about changing the layout of the service URLs.
This call was probably the only service to service call circa 2021. GridClient seems to be how more recent service to service calls are done.
Get SourceImage requests additional fields via media-api query parameters so add queryStringParameters parameter to makeGetRequestAsync.
Extract the media api uri to image id validation to a function for testing and make it validate image URIs rather than blanket Media API.
How should a reviewer test this change?
How can success be measured?
Who should look at this?
Tested? Documented?