chore: add DevX owner tag to auth lambda #2804
Merged
+11
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
DevX maintains the application code and infrastructure definition for the
auth-lambda(which is part of https://github.com/guardian/cognito-auth-lambdas).We don't expect teams to modify this Lambda directly themselves, however they do need to keep its infrastructure up to date by upgrading GuCDK when necessary.
This PR adds an
Ownertag to try to make this split of responsibilities clearer to teams.How to test
Grafana uses the relevant Google Auth feature, so I've created an example PR which pulls in this change. Note that the Lambda and its IAM role both get this tag; I think this is fine as we expect DevX to manage both of these resources via library and
cognito-auth-lambdaschanges.How can we measure success?
The main motivation for this change is the fact that we're about to send comms publicising the runtimes that AWS will deprecate this year. The
auth-lambdais using theprovided.al2runtime which will be deprecated this summer.As this Lambda is provisioned in several AWS accounts, it'd be nice to clarify ownership for teams so they don't think that they need to upgrade this runtime themselves.
DevX Reliability and Operations have a Trello goal for upgrading this runtime.
Have we considered potential risks?
The split of responsibilities here is a little unusual. Normally infrastructure with this
Ownertag is maintained and deployed by DevX (example). I'd be interested to hear whether others think this new tag actually makes things clearer or not!