perf: optimize picker consistent hash by eliminating map lookup (#13) #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace hashMap with entry struct that stores hash and client together, eliminating the map lookup after binary search in Get(). This optimization was ported from groupcache2 where it showed ~15-25% improvement in Get() operations.
abhishek-singla-97
force-pushed
the
optimize-consistent-hash-picker
branch
from
fbec36a to
8af89bb
Compare
Author
|
@thrawn01 can you take a look at this? Pretty small change as in the issue discussion, didn't do anything new. Hope it was still required as I saw it was tagged "help wanted". |
thrawn01
approved these changes
Dec 25, 2025
Contributor
thrawn01
left a comment
thrawn01
left a comment
There was a problem hiding this comment.
Thank you for making this PR! ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes the consistent hash picker by eliminating the
hashMapmap lookup in theGet()method as suggested in #13Changes
entrystruct that stores both the hash value and client reference togetherkeys []int+hashMap map[int]Clientwithkeys []entryAdd()to usesort.Sliceinstead ofsort.IntsGet()to access client directly fromentry.clientBenchmark Results (Apple M1 Pro)