Skip to content

Conversation

@Tochemey
Copy link
Contributor

@Tochemey Tochemey commented Dec 6, 2025

  • Fix some ci pipeline bugs when running tracer in parallel due the global nature of otel tracer
  • Add RemoveKeys to the Cache interface and implement it for mutexCache and OtterCache

This PR should address the issue raised #17. cc: @thrawn01

@Tochemey
Copy link
Contributor Author

Tochemey commented Dec 6, 2025

@thrawn01 if that sounds ok with you we can close the issue #17 once this PR is merged because we already have RemoveGroup

@thrawn01
Copy link
Contributor

thrawn01 commented Dec 8, 2025

Thanks for taking the time to make this PR. However, I don't understand the intent!?

If the intent of issue #17 was to efficiently remove multiple keys across the cluster, this PR doesn't address that. We would need to implement group.RemoveKeys(ctx, keys...)

I also don't understand the need for parallel in RemoveKeys(parallel=true) as the LRU implementation uses a mutex which would negate the benefits of any concurrency. Even when using Otter cache, the benefits would be minimal to non-existent as there is more overhead in setting up the go routines than in removing the items from the cache.

Is your intent to efficiently remove multiple keys across the cluster?

@thrawn01 thrawn01 self-requested a review December 8, 2025 22:57
@Tochemey
Copy link
Contributor Author

Tochemey commented Dec 9, 2025

@thrawn01 Thanks for reviewing the PR. I think we need to align clearly on the intent. I can close this PR and we can revisit it once the intent is clear.

@Tochemey Tochemey closed this Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants