Skip to content

Conversation

@Tochemey
Copy link
Contributor

@Tochemey Tochemey commented Nov 30, 2025

  • Added OpenTelemetry tracing tests for HTTP transport and client when a tracer is configured, ensuring spans are emitted with correct statuses/attributes and server handler wiring is active. Introduced tracing-focused test stubs for transport.
  • Implemented full GroupMetric registration and accessors, aligning metrics with GroupStats fields and adding a peer-latency gauge.
  • Added a metrics plumbing suite in stats_test.go to cover meter provider defaults/overrides and to exercise success/error paths for group/cache instruments and NewGroup metric registration failures; added recording/failing meter fakes.
  • Added NewGroup tests that validate metric registration succeeds (and instruments/counts are correct) and that failures propagate.

@thrawn01 whenever free kindly review this PR

@Tochemey Tochemey changed the title feat: ✨ add opentelemetry tracing feat: ✨ add opentelemetry instrumentation Nov 30, 2025
Copy link
Contributor

@thrawn01 thrawn01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spending the time to implement this, this is great!

@thrawn01 thrawn01 merged commit fb6d198 into groupcache:main Dec 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants