Ci experiments #10
Open
Ci experiments #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graydon
force-pushed
the
ci-experiments
branch
from
77f2cae to
71619dd
Compare
# Description Fixes a bug where the `RandomEvictionCache` seed was not properly set. # Checklist - [x] Reviewed the [contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes) document - [x] Rebased on top of master (no merge commits) - [x] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio extension) - [x] Compiles - [x] Ran all tests - [ ] If change impacts performance, include supporting evidence per the [performance document](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)
# Description Fixes two bugs in apply load: 1. We were incrementing our ledger seq by one too much during BucketList setup, causing issues with the BucketList spill logic. 2. Temporary meta file was being deleted immediately after being set up. # Checklist - [x] Reviewed the [contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes) document - [x] Rebased on top of master (no merge commits) - [x] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio extension) - [x] Compiles - [x] Ran all tests - [ ] If change impacts performance, include supporting evidence per the [performance document](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)
# Description None of the caches use the global prng anymore, so we can remove the constructor that allows it's usage. <!--- Describe what this pull request does, which issue it's resolving (usually applicable for code changes). ---> # Checklist - [ ] Reviewed the [contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes) document - [ ] Rebased on top of master (no merge commits) - [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio extension) - [ ] Compiles - [ ] Ran all tests - [ ] If change impacts performance, include supporting evidence per the [performance document](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)
…onments) This test is obsolete in the first place (we don't build on clang 8 at all anymore) but also, incidentally, since it runs AC_RUN_IFELSE it winds up executing a binary it built, and this happens after asan is enabled, and so in a few specific environments where asan doesn't work (eg. old versions of docker when running under qemu-user; also seemingly pbuilder) this causes configuration to fail entirely. There's no real way to make asan work in these environments, we have to just avoid running conftests after asan is turned on. We could move this test above the asan enabling part of configure, but again, it's an obsolete test; simpler just to remove it entirely.
…onments) (stellar#4938) This test is obsolete in the first place (we don't build on clang 8 at all anymore) but also, incidentally, since it runs AC_RUN_IFELSE it winds up executing a binary it built, and this happens after asan is enabled, and so in a few specific environments where asan doesn't work (eg. old versions of docker when running under qemu-user; also seemingly pbuilder) this causes configuration to fail entirely. There's no real way to make asan work in these environments, we have to just avoid running conftests after asan is turned on. We could move this test above the asan enabling part of configure, but again, it's an obsolete test; simpler just to remove it entirely. (The underlying qemu issue appears to be this: https://gitlab.com/qemu-project/qemu/-/issues/290)
### What Update docker building to support Ubuntu 24.04 ### Why We need to start publishing 24.04 packages
stellar#4928 What * update docker building to support Ubuntu 24.04 # Why We need to start publishing 24.04 packages # Checklist - [x] Reviewed the [contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes) document - [x] Rebased on top of master (no merge commits) - [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio extension) - [ ] Compiles - [ ] Ran all tests - [ ] If change impacts performance, include supporting evidence per the [performance document](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)
graydon
force-pushed
the
ci-experiments
branch
from
5f23b67 to
39a63ce
Compare
graydon
force-pushed
the
ci-experiments
branch
from
39a63ce to
4b392f4
Compare
graydon
force-pushed
the
ci-experiments
branch
from
1c16752 to
a2547be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tinkering with CI